Skip to content

Commit c249687

Browse files
Yuuoniykraxel
authored andcommitted
drm/virtio: Fix NULL vs IS_ERR checking in virtio_gpu_object_shmem_init
Since drm_prime_pages_to_sg() function return error pointers. The drm_gem_shmem_get_sg_table() function returns error pointers too. Using IS_ERR() to check the return value to fix this. Fixes: 2f2aa13 ("drm/virtio: move virtio_gpu_mem_entry initialization to new function") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> Link: http://patchwork.freedesktop.org/patch/msgid/20220602104223.54527-1-linmq006@gmail.com Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
1 parent 9e9fa6a commit c249687

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/gpu/drm/virtio/virtgpu_object.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -168,9 +168,9 @@ static int virtio_gpu_object_shmem_init(struct virtio_gpu_device *vgdev,
168168
* since virtio_gpu doesn't support dma-buf import from other devices.
169169
*/
170170
shmem->pages = drm_gem_shmem_get_sg_table(&bo->base);
171-
if (!shmem->pages) {
171+
if (IS_ERR(shmem->pages)) {
172172
drm_gem_shmem_unpin(&bo->base);
173-
return -EINVAL;
173+
return PTR_ERR(shmem->pages);
174174
}
175175

176176
if (use_dma_api) {

0 commit comments

Comments
 (0)