Skip to content

Commit cfe03c2

Browse files
author
Christoph Hellwig
committed
nvmet: avoid double errno conversions
Use errno_to_nvme_status to convert from a negative errno to a nvme status field instead of going through a blk_status_t. Also remove the pointless status variable in nvmet_bdev_execute_write_zeroes. Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Sagi Grimberg <sagi@grimberg.me> Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
1 parent 43e2d08 commit cfe03c2

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

drivers/nvme/target/io-cmd-bdev.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ static u16 nvmet_bdev_discard_range(struct nvmet_req *req,
196196
GFP_KERNEL, 0, bio);
197197
if (ret && ret != -EOPNOTSUPP) {
198198
req->error_slba = le64_to_cpu(range->slba);
199-
return blk_to_nvme_status(req, errno_to_blk_status(ret));
199+
return errno_to_nvme_status(req, ret);
200200
}
201201
return NVME_SC_SUCCESS;
202202
}
@@ -252,7 +252,6 @@ static void nvmet_bdev_execute_write_zeroes(struct nvmet_req *req)
252252
{
253253
struct nvme_write_zeroes_cmd *write_zeroes = &req->cmd->write_zeroes;
254254
struct bio *bio = NULL;
255-
u16 status = NVME_SC_SUCCESS;
256255
sector_t sector;
257256
sector_t nr_sector;
258257
int ret;
@@ -264,13 +263,12 @@ static void nvmet_bdev_execute_write_zeroes(struct nvmet_req *req)
264263

265264
ret = __blkdev_issue_zeroout(req->ns->bdev, sector, nr_sector,
266265
GFP_KERNEL, &bio, 0);
267-
status = blk_to_nvme_status(req, errno_to_blk_status(ret));
268266
if (bio) {
269267
bio->bi_private = req;
270268
bio->bi_end_io = nvmet_bio_done;
271269
submit_bio(bio);
272270
} else {
273-
nvmet_req_complete(req, status);
271+
nvmet_req_complete(req, errno_to_nvme_status(req, ret));
274272
}
275273
}
276274

0 commit comments

Comments
 (0)