Skip to content

Commit d2ead1f

Browse files
Tariq Toukandavem330
Tariq Toukan
authored and
davem330
committed
net/mlx5e: Add kTLS TX HW offload support
Add support for transmit side kernel-TLS acceleration. Offload the crypto encryption to HW. Per TLS connection: - Use a separate TIS to maintain the HW context. - Use a separate encryption key. - Maintain static and progress HW contexts by posting the proper WQEs at creation time, or upon resync. - Use a special DUMP opcode to replay the previous frags and sync the HW context. To make sure the SQ is able to serve an xmit request, increase SQ stop room to cover: - static params WQE, - progress params WQE, and - resync DUMP per frag. Currently supporting TLS 1.2, and key size 128bit. Tested over SimX simulator. Signed-off-by: Tariq Toukan <tariqt@mellanox.com> Signed-off-by: Eran Ben Elisha <eranbe@mellanox.com> Signed-off-by: Saeed Mahameed <saeedm@mellanox.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 37badd1 commit d2ead1f

File tree

14 files changed

+748
-7
lines changed

14 files changed

+748
-7
lines changed

‎drivers/net/ethernet/mellanox/mlx5/core/Makefile‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,4 +62,5 @@ mlx5_core-$(CONFIG_MLX5_FPGA) += fpga/cmd.o fpga/core.o fpga/conn.o fpga/sdk.o
6262
mlx5_core-$(CONFIG_MLX5_EN_IPSEC) += en_accel/ipsec.o en_accel/ipsec_rxtx.o \
6363
en_accel/ipsec_stats.o
6464

65-
mlx5_core-$(CONFIG_MLX5_EN_TLS) += en_accel/tls.o en_accel/tls_rxtx.o en_accel/tls_stats.o
65+
mlx5_core-$(CONFIG_MLX5_EN_TLS) += en_accel/tls.o en_accel/tls_rxtx.o en_accel/tls_stats.o \
66+
en_accel/ktls.o en_accel/ktls_tx.o

‎drivers/net/ethernet/mellanox/mlx5/core/en.h‎

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,10 @@ struct mlx5e_umr_wqe {
209209
struct mlx5_wqe_ctrl_seg ctrl;
210210
struct mlx5_wqe_umr_ctrl_seg uctrl;
211211
struct mlx5_mkey_seg mkc;
212-
struct mlx5_mtt inline_mtts[0];
212+
union {
213+
struct mlx5_mtt inline_mtts[0];
214+
u8 tls_static_params_ctx[0];
215+
};
213216
};
214217

215218
extern const char mlx5e_self_tests[][ETH_GSTRING_LEN];
@@ -333,6 +336,9 @@ struct mlx5e_tx_wqe_info {
333336
u32 num_bytes;
334337
u8 num_wqebbs;
335338
u8 num_dma;
339+
#ifdef CONFIG_MLX5_EN_TLS
340+
skb_frag_t *resync_dump_frag;
341+
#endif
336342
};
337343

338344
enum mlx5e_dma_map_type {

‎drivers/net/ethernet/mellanox/mlx5/core/en/txrx.h‎

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,15 @@
1515
#else
1616
/* TLS offload requires additional stop_room for:
1717
* - a resync SKB.
18+
* kTLS offload requires additional stop_room for:
19+
* - static params WQE,
20+
* - progress params WQE, and
21+
* - resync DUMP per frag.
1822
*/
1923
#define MLX5E_SQ_TLS_ROOM \
20-
(MLX5_SEND_WQE_MAX_WQEBBS)
24+
(MLX5_SEND_WQE_MAX_WQEBBS + \
25+
MLX5E_KTLS_STATIC_WQEBBS + MLX5E_KTLS_PROGRESS_WQEBBS + \
26+
MAX_SKB_FRAGS * MLX5E_KTLS_MAX_DUMP_WQEBBS)
2127
#endif
2228

2329
#define INL_HDR_START_SZ (sizeof(((struct mlx5_wqe_eth_seg *)NULL)->inline_hdr.start))

‎drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.c‎

Lines changed: 93 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,93 @@
1+
// SPDX-License-Identifier: GPL-2.0 OR Linux-OpenIB
2+
// Copyright (c) 2019 Mellanox Technologies.
3+
4+
#include "en.h"
5+
#include "en_accel/ktls.h"
6+
7+
static int mlx5e_ktls_create_tis(struct mlx5_core_dev *mdev, u32 *tisn)
8+
{
9+
u32 in[MLX5_ST_SZ_DW(create_tis_in)] = {};
10+
void *tisc;
11+
12+
tisc = MLX5_ADDR_OF(create_tis_in, in, ctx);
13+
14+
MLX5_SET(tisc, tisc, tls_en, 1);
15+
16+
return mlx5e_create_tis(mdev, in, tisn);
17+
}
18+
19+
static int mlx5e_ktls_add(struct net_device *netdev, struct sock *sk,
20+
enum tls_offload_ctx_dir direction,
21+
struct tls_crypto_info *crypto_info,
22+
u32 start_offload_tcp_sn)
23+
{
24+
struct mlx5e_priv *priv = netdev_priv(netdev);
25+
struct mlx5e_ktls_offload_context_tx *tx_priv;
26+
struct tls_context *tls_ctx = tls_get_ctx(sk);
27+
struct mlx5_core_dev *mdev = priv->mdev;
28+
int err;
29+
30+
if (WARN_ON(direction != TLS_OFFLOAD_CTX_DIR_TX))
31+
return -EINVAL;
32+
33+
if (WARN_ON(!mlx5e_ktls_type_check(mdev, crypto_info)))
34+
return -EOPNOTSUPP;
35+
36+
tx_priv = kvzalloc(sizeof(*tx_priv), GFP_KERNEL);
37+
if (!tx_priv)
38+
return -ENOMEM;
39+
40+
tx_priv->expected_seq = start_offload_tcp_sn;
41+
tx_priv->crypto_info = crypto_info;
42+
mlx5e_set_ktls_tx_priv_ctx(tls_ctx, tx_priv);
43+
44+
/* tc and underlay_qpn values are not in use for tls tis */
45+
err = mlx5e_ktls_create_tis(mdev, &tx_priv->tisn);
46+
if (err)
47+
goto create_tis_fail;
48+
49+
err = mlx5_ktls_create_key(mdev, crypto_info, &tx_priv->key_id);
50+
if (err)
51+
goto encryption_key_create_fail;
52+
53+
mlx5e_ktls_tx_offload_set_pending(tx_priv);
54+
55+
return 0;
56+
57+
encryption_key_create_fail:
58+
mlx5e_destroy_tis(priv->mdev, tx_priv->tisn);
59+
create_tis_fail:
60+
kvfree(tx_priv);
61+
return err;
62+
}
63+
64+
static void mlx5e_ktls_del(struct net_device *netdev,
65+
struct tls_context *tls_ctx,
66+
enum tls_offload_ctx_dir direction)
67+
{
68+
struct mlx5e_priv *priv = netdev_priv(netdev);
69+
struct mlx5e_ktls_offload_context_tx *tx_priv =
70+
mlx5e_get_ktls_tx_priv_ctx(tls_ctx);
71+
72+
mlx5_ktls_destroy_key(priv->mdev, tx_priv->key_id);
73+
mlx5e_destroy_tis(priv->mdev, tx_priv->tisn);
74+
kvfree(tx_priv);
75+
}
76+
77+
static const struct tlsdev_ops mlx5e_ktls_ops = {
78+
.tls_dev_add = mlx5e_ktls_add,
79+
.tls_dev_del = mlx5e_ktls_del,
80+
};
81+
82+
void mlx5e_ktls_build_netdev(struct mlx5e_priv *priv)
83+
{
84+
struct net_device *netdev = priv->netdev;
85+
86+
if (!mlx5_accel_is_ktls_device(priv->mdev))
87+
return;
88+
89+
netdev->hw_features |= NETIF_F_HW_TLS_TX;
90+
netdev->features |= NETIF_F_HW_TLS_TX;
91+
92+
netdev->tlsdev_ops = &mlx5e_ktls_ops;
93+
}

‎drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.h‎

Lines changed: 97 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,97 @@
1+
/* SPDX-License-Identifier: GPL-2.0 OR Linux-OpenIB */
2+
/* Copyright (c) 2019 Mellanox Technologies. */
3+
4+
#ifndef __MLX5E_KTLS_H__
5+
#define __MLX5E_KTLS_H__
6+
7+
#include "en.h"
8+
9+
#ifdef CONFIG_MLX5_EN_TLS
10+
#include <net/tls.h>
11+
#include "accel/tls.h"
12+
13+
#define MLX5E_KTLS_STATIC_UMR_WQE_SZ \
14+
(sizeof(struct mlx5e_umr_wqe) + MLX5_ST_SZ_BYTES(tls_static_params))
15+
#define MLX5E_KTLS_STATIC_WQEBBS \
16+
(DIV_ROUND_UP(MLX5E_KTLS_STATIC_UMR_WQE_SZ, MLX5_SEND_WQE_BB))
17+
18+
#define MLX5E_KTLS_PROGRESS_WQE_SZ \
19+
(sizeof(struct mlx5e_tx_wqe) + MLX5_ST_SZ_BYTES(tls_progress_params))
20+
#define MLX5E_KTLS_PROGRESS_WQEBBS \
21+
(DIV_ROUND_UP(MLX5E_KTLS_PROGRESS_WQE_SZ, MLX5_SEND_WQE_BB))
22+
#define MLX5E_KTLS_MAX_DUMP_WQEBBS 2
23+
24+
enum {
25+
MLX5E_TLS_PROGRESS_PARAMS_AUTH_STATE_NO_OFFLOAD = 0,
26+
MLX5E_TLS_PROGRESS_PARAMS_AUTH_STATE_OFFLOAD = 1,
27+
MLX5E_TLS_PROGRESS_PARAMS_AUTH_STATE_AUTHENTICATION = 2,
28+
};
29+
30+
enum {
31+
MLX5E_TLS_PROGRESS_PARAMS_RECORD_TRACKER_STATE_START = 0,
32+
MLX5E_TLS_PROGRESS_PARAMS_RECORD_TRACKER_STATE_SEARCHING = 1,
33+
MLX5E_TLS_PROGRESS_PARAMS_RECORD_TRACKER_STATE_TRACKING = 2,
34+
};
35+
36+
struct mlx5e_ktls_offload_context_tx {
37+
struct tls_offload_context_tx *tx_ctx;
38+
struct tls_crypto_info *crypto_info;
39+
u32 expected_seq;
40+
u32 tisn;
41+
u32 key_id;
42+
bool ctx_post_pending;
43+
};
44+
45+
struct mlx5e_ktls_offload_context_tx_shadow {
46+
struct tls_offload_context_tx tx_ctx;
47+
struct mlx5e_ktls_offload_context_tx *priv_tx;
48+
};
49+
50+
static inline void
51+
mlx5e_set_ktls_tx_priv_ctx(struct tls_context *tls_ctx,
52+
struct mlx5e_ktls_offload_context_tx *priv_tx)
53+
{
54+
struct tls_offload_context_tx *tx_ctx = tls_offload_ctx_tx(tls_ctx);
55+
struct mlx5e_ktls_offload_context_tx_shadow *shadow;
56+
57+
BUILD_BUG_ON(sizeof(*shadow) > TLS_OFFLOAD_CONTEXT_SIZE_TX);
58+
59+
shadow = (struct mlx5e_ktls_offload_context_tx_shadow *)tx_ctx;
60+
61+
shadow->priv_tx = priv_tx;
62+
priv_tx->tx_ctx = tx_ctx;
63+
}
64+
65+
static inline struct mlx5e_ktls_offload_context_tx *
66+
mlx5e_get_ktls_tx_priv_ctx(struct tls_context *tls_ctx)
67+
{
68+
struct tls_offload_context_tx *tx_ctx = tls_offload_ctx_tx(tls_ctx);
69+
struct mlx5e_ktls_offload_context_tx_shadow *shadow;
70+
71+
BUILD_BUG_ON(sizeof(*shadow) > TLS_OFFLOAD_CONTEXT_SIZE_TX);
72+
73+
shadow = (struct mlx5e_ktls_offload_context_tx_shadow *)tx_ctx;
74+
75+
return shadow->priv_tx;
76+
}
77+
78+
void mlx5e_ktls_build_netdev(struct mlx5e_priv *priv);
79+
void mlx5e_ktls_tx_offload_set_pending(struct mlx5e_ktls_offload_context_tx *priv_tx);
80+
81+
struct sk_buff *mlx5e_ktls_handle_tx_skb(struct net_device *netdev,
82+
struct mlx5e_txqsq *sq,
83+
struct sk_buff *skb,
84+
struct mlx5e_tx_wqe **wqe, u16 *pi);
85+
void mlx5e_ktls_tx_handle_resync_dump_comp(struct mlx5e_txqsq *sq,
86+
struct mlx5e_tx_wqe_info *wi,
87+
struct mlx5e_sq_dma *dma);
88+
89+
#else
90+
91+
static inline void mlx5e_ktls_build_netdev(struct mlx5e_priv *priv)
92+
{
93+
}
94+
95+
#endif
96+
97+
#endif /* __MLX5E_TLS_H__ */

0 commit comments

Comments
 (0)