Skip to content

Commit e5093ae

Browse files
Jarek Poplawskidavem330
authored andcommitted
net: Fix a memmove bug in dev_gro_receive()
>Xin Xiaohui wrote: > I looked into the code dev_gro_receive(), found the code here: > if the frags[0] is pulled to 0, then the page will be released, > and memmove() frags left. > Is that right? I'm not sure if memmove do right or not, but > frags[0].size is never set after memove at least. what I think > a simple way is not to do anything if we found frags[0].size == 0. > The patch is as followed. ... This version of the patch fixes the bug directly in memmove. Reported-by: "Xin, Xiaohui" <xiaohui.xin@intel.com> Signed-off-by: Jarek Poplawski <jarkao2@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 1c40be1 commit e5093ae

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

net/core/dev.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3143,7 +3143,7 @@ enum gro_result dev_gro_receive(struct napi_struct *napi, struct sk_buff *skb)
31433143
put_page(skb_shinfo(skb)->frags[0].page);
31443144
memmove(skb_shinfo(skb)->frags,
31453145
skb_shinfo(skb)->frags + 1,
3146-
--skb_shinfo(skb)->nr_frags);
3146+
--skb_shinfo(skb)->nr_frags * sizeof(skb_frag_t));
31473147
}
31483148
}
31493149

0 commit comments

Comments
 (0)