wifi: iwlwifi: Fix memory leak in iwl_mvm_init()

Xiu Jianfeng · Miriam-Rachel · commit ed2e916c8909 · 2025-06-25T10:57:34.000+03:00
When iwl_opmode_register() fails, it does not unregster rate control, which will cause a memory leak issue, this patch fixes it. Fixes: 9f66a39 ("iwlwifi: mvm: rs: add ops for the new rate scaling in the FW") Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com> Link: https://patch.msgid.link/20221109035213.570-1-xiujianfeng@huawei.com Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/ops.c b/drivers/net/wireless/intel/iwlwifi/mvm/ops.c
@@ -61,8 +61,10 @@ static int __init iwl_mvm_init(void)
 	}
 
 	ret = iwl_opmode_register("iwlmvm", &iwl_mvm_ops);
-	if (ret)
+	if (ret) {
 		pr_err("Unable to register MVM op_mode: %d\n", ret);
+		iwl_mvm_rate_control_unregister();
+	}
 
 	return ret;
 }

Original file line number	Diff line number	Diff line change
`@@ -61,8 +61,10 @@ static int __init iwl_mvm_init(void)`
`61`	`61`	`}`
`62`	`62`
`63`	`63`	`ret = iwl_opmode_register("iwlmvm", &iwl_mvm_ops);`
`64`		`- if (ret)`
	`64`	`+ if (ret) {`
`65`	`65`	`pr_err("Unable to register MVM op_mode: %d\n", ret);`
	`66`	`+ iwl_mvm_rate_control_unregister();`
	`67`	`+ }`
`66`	`68`
`67`	`69`	`return ret;`
`68`	`70`	`}`