Skip to content

Commit f1738a1

Browse files
robimarkostorulf
authored andcommitted
mmc: core: disable TRIM on Kingston EMMC04G-M627
It seems that Kingston EMMC04G-M627 despite advertising TRIM support does not work when the core is trying to use REQ_OP_WRITE_ZEROES. We are seeing I/O errors in OpenWrt under 6.1 on Zyxel NBG7815 that we did not previously have and tracked it down to REQ_OP_WRITE_ZEROES. Trying to use fstrim seems to also throw errors like: [93010.835112] I/O error, dev loop0, sector 16902 op 0x3:(DISCARD) flags 0x800 phys_seg 1 prio class 2 Disabling TRIM makes the error go away, so lets add a quirk for this eMMC to disable TRIM. Signed-off-by: Robert Marko <robimarko@gmail.com> Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20230619193621.437358-1-robimarko@gmail.com Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
1 parent b5c3eb3 commit f1738a1

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

drivers/mmc/core/quirks.h

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,13 @@ static const struct mmc_fixup __maybe_unused mmc_blk_fixups[] = {
107107
MMC_FIXUP("Q2J54A", CID_MANFID_MICRON, 0x014e, add_quirk_mmc,
108108
MMC_QUIRK_TRIM_BROKEN),
109109

110+
/*
111+
* Kingston EMMC04G-M627 advertises TRIM but it does not seems to
112+
* support being used to offload WRITE_ZEROES.
113+
*/
114+
MMC_FIXUP("M62704", CID_MANFID_KINGSTON, 0x0100, add_quirk_mmc,
115+
MMC_QUIRK_TRIM_BROKEN),
116+
110117
/*
111118
* Some SD cards reports discard support while they don't
112119
*/

0 commit comments

Comments
 (0)