Skip to content

Commit f378ab7

Browse files
vsyrjalarodrigovivi
authored andcommitted
drm/i915: Stop doing double audio enable/disable on SDVO and g4x+ DP
Looks like I misplaced a few hunks when I moved the audio enable/disable out from the encoder enable/disable hooks. So we are now doing a double audio enable/disable on SDVO and g4x+ DP. Probably harmless as doing it twice shouldn't really change anything, but let's do it just once, as intended. Fixes: cff742c ("drm/i915: Hoist the encoder->audio_{enable,disable}() calls higher up") Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20240226193251.29619-1-ville.syrjala@linux.intel.com Reviewed-by: Jani Nikula <jani.nikula@intel.com> (cherry picked from commit 315bd0a) Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
1 parent 5acb32b commit f378ab7

File tree

2 files changed

+0
-6
lines changed

2 files changed

+0
-6
lines changed

drivers/gpu/drm/i915/display/g4x_dp.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -717,7 +717,6 @@ static void g4x_enable_dp(struct intel_atomic_state *state,
717717
{
718718
intel_enable_dp(state, encoder, pipe_config, conn_state);
719719
intel_edp_backlight_on(pipe_config, conn_state);
720-
encoder->audio_enable(encoder, pipe_config, conn_state);
721720
}
722721

723722
static void vlv_enable_dp(struct intel_atomic_state *state,
@@ -726,7 +725,6 @@ static void vlv_enable_dp(struct intel_atomic_state *state,
726725
const struct drm_connector_state *conn_state)
727726
{
728727
intel_edp_backlight_on(pipe_config, conn_state);
729-
encoder->audio_enable(encoder, pipe_config, conn_state);
730728
}
731729

732730
static void g4x_pre_enable_dp(struct intel_atomic_state *state,

drivers/gpu/drm/i915/display/intel_sdvo.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1842,8 +1842,6 @@ static void intel_disable_sdvo(struct intel_atomic_state *state,
18421842
struct intel_crtc *crtc = to_intel_crtc(old_crtc_state->uapi.crtc);
18431843
u32 temp;
18441844

1845-
encoder->audio_disable(encoder, old_crtc_state, conn_state);
1846-
18471845
intel_sdvo_set_active_outputs(intel_sdvo, 0);
18481846
if (0)
18491847
intel_sdvo_set_encoder_power_state(intel_sdvo,
@@ -1935,8 +1933,6 @@ static void intel_enable_sdvo(struct intel_atomic_state *state,
19351933
intel_sdvo_set_encoder_power_state(intel_sdvo,
19361934
DRM_MODE_DPMS_ON);
19371935
intel_sdvo_set_active_outputs(intel_sdvo, intel_sdvo_connector->output_flag);
1938-
1939-
encoder->audio_enable(encoder, pipe_config, conn_state);
19401936
}
19411937

19421938
static enum drm_mode_status

0 commit comments

Comments
 (0)