Skip to content

Commit fa376ac

Browse files
animesh-mannavsyrjala
authored andcommitted
drm/i915/panelreplay: Panel replay workaround with VRR
Panel Replay VSC SDP not getting sent when VRR is enabled and W1 and W2 are 0. So Program Set Context Latency in TRANS_SET_CONTEXT_LATENCY register to at least a value of 1. The same is applicable for PSR1/PSR2 as well. HSD: 14015406119 v1: Initial version. v2: Update timings stored in adjusted_mode struct. [Ville] v3: Add WA in compute_config(). [Ville] v4: - Add DISPLAY_VER() check and improve code comment. [Rodrigo] - Introduce centralized intel_crtc_vblank_delay(). [Ville] v5: Move to crtc_compute_config(). [Ville] v6: Restrict DISPLAY_VER till 14. [Mitul] v7: - Corrected code-comment. [Mitul] - dev_priv local variable removed. [Jani] v8: Introduce late_compute_config() which will take care late vblank-delay adjustment. [Ville] v9: Implementation simplified and split into multiple patches. v10: - Split vrr changes and use struct intel_display in DISPLAY_VER(). [Ankit] - Use for_each_new_intel_connector_in_state(). [Jani] v11: Remove loop and use flipline instead of vrr.enable flag. [Ville] v12: - Use intel_Vrr_possible helper. - Correct flag check for flipline. v13: - Refactor workaround [Jonathan] - Drop the comment around woraround number. [Ville] Signed-off-by: Animesh Manna <animesh.manna@intel.com> Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com> Reviewed-by: Jonathan Cavitt <jonathan.cavitt@intel.com> [vsyrjala: Make adjusted_modeg const, and drop redundant parens] Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20241010040503.1795399-4-mitulkumar.ajitkumar.golani@intel.com
1 parent 96abbed commit fa376ac

File tree

1 file changed

+16
-0
lines changed

1 file changed

+16
-0
lines changed

drivers/gpu/drm/i915/display/intel_display.c

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2609,13 +2609,29 @@ static int intel_crtc_compute_pipe_mode(struct intel_crtc_state *crtc_state)
26092609
return 0;
26102610
}
26112611

2612+
static bool intel_crtc_needs_wa_14015401596(struct intel_crtc_state *crtc_state)
2613+
{
2614+
struct intel_display *display = to_intel_display(crtc_state);
2615+
const struct drm_display_mode *adjusted_mode = &crtc_state->hw.adjusted_mode;
2616+
2617+
return intel_vrr_possible(crtc_state) && crtc_state->has_psr &&
2618+
adjusted_mode->crtc_vblank_start == adjusted_mode->crtc_vdisplay &&
2619+
IS_DISPLAY_VER(display, 13, 14);
2620+
}
2621+
26122622
static int intel_crtc_compute_config(struct intel_atomic_state *state,
26132623
struct intel_crtc *crtc)
26142624
{
26152625
struct intel_crtc_state *crtc_state =
26162626
intel_atomic_get_new_crtc_state(state, crtc);
2627+
struct drm_display_mode *adjusted_mode =
2628+
&crtc_state->hw.adjusted_mode;
26172629
int ret;
26182630

2631+
/* Wa_14015401596 */
2632+
if (intel_crtc_needs_wa_14015401596(crtc_state))
2633+
adjusted_mode->crtc_vblank_start += 1;
2634+
26192635
ret = intel_dpll_crtc_compute_clock(state, crtc);
26202636
if (ret)
26212637
return ret;

0 commit comments

Comments
 (0)