Skip to content

Commit fd0ccaf

Browse files
lizf-ostorvalds
authored andcommitted
memcg: avoid accessing memcg after releasing reference
This might cause a use-after-free bug. Signed-off-by: Li Zefan <lizefan@huawei.com> Cc: Glauber Costa <glommer@parallels.com> Acked-by: Michal Hocko <mhocko@suse.cz> Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> Cc: Johannes Weiner <hannes@cmpxchg.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 865ffef commit fd0ccaf

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

mm/memcontrol.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3215,12 +3215,12 @@ void memcg_release_cache(struct kmem_cache *s)
32153215

32163216
root = s->memcg_params->root_cache;
32173217
root->memcg_params->memcg_caches[id] = NULL;
3218-
mem_cgroup_put(memcg);
32193218

32203219
mutex_lock(&memcg->slab_caches_mutex);
32213220
list_del(&s->memcg_params->list);
32223221
mutex_unlock(&memcg->slab_caches_mutex);
32233222

3223+
mem_cgroup_put(memcg);
32243224
out:
32253225
kfree(s->memcg_params);
32263226
}

0 commit comments

Comments
 (0)