New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Result set names are the only way to configure dbic #16

Merged
merged 4 commits into from Jan 23, 2017

Conversation

Projects
None yet
2 participants
@simbabque
Contributor

simbabque commented Jan 21, 2017

I've implemented the changes we discussed to make the _resultset config values the only way to configure DBIC. Both _table and _source are deprecated and issue warnings when they are used. I've added a new test to make sure this is the case. In the documentation both sets of options are now in a new section and have been removed from the normal options list and the examples.

This is my entry for the PRC 2017.

Closes #12

@SysPete SysPete merged commit 7d9c760 into ctrlo:master Jan 23, 2017

@SysPete

This comment has been minimized.

Show comment
Hide comment
@SysPete

SysPete Jan 23, 2017

Collaborator

Many thanks @simbabque! New release on its way to CPAN.

Collaborator

SysPete commented Jan 23, 2017

Many thanks @simbabque! New release on its way to CPAN.

@simbabque simbabque deleted the simbabque:result-source-only branch Jan 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment