feat: create relationship between parent cluster and vclusters

[adityachoudhari26]

Summary by CodeRabbit

• New Features
  • Added automatic creation of resource relationship rules linking vcluster resources to their parent clusters for supported cloud providers.
• Improvements
  • Enhanced handling of existing resource relationship rules to avoid errors when rules already exist.
  • Improved logging for resource synchronization and relationship rule creation.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This change introduces formal creation of resource relationship rules linking vcluster resources to their parent clusters, with cloud-provider-specific metadata keys. It adds helper functions for kind string generation, new constants for cluster kinds and metadata, and updates logging and error handling in resource provider and sync command logic.

Changes

File(s)	Change Summary
cmd/ctrlc/root/sync/kubernetes/vcluster.go	Refactored vcluster kind generation, added createResourceRelationshipRule function, updated sync logic, improved logging.
internal/api/resource_provider.go	Enhanced AddResourceRelationshipRule to handle HTTP 409 Conflict, added logging for existing/success cases.
internal/kinds/db.go	Added constants for cloud provider metadata keys and cluster kinds, including vcluster kind.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant CLI
    participant ResourceProvider
    participant API

    User->>CLI: Execute vcluster sync command
    CLI->>CLI: Generate vcluster metadata and kind
    CLI->>ResourceProvider: Upsert vcluster resource
    ResourceProvider->>API: Send upsert request
    API-->>ResourceProvider: Response
    CLI->>CLI: Generate resource relationship rule
    CLI->>ResourceProvider: AddResourceRelationshipRule
    ResourceProvider->>API: Send relationship rule request
    API-->>ResourceProvider: Response (success or 409 Conflict)
    ResourceProvider-->>CLI: Log outcome

Loading

Possibly related PRs

• fix: GKE scan #22: Both PRs involve resource relationship rules, but this one focuses on kind/version assignment for GKE rules, while the main PR introduces rule creation for vcluster resources.
• chore: cleanup vcluster scan #30: This PR is a direct continuation, further modifying vcluster kind generation and adding relationship rule creation, building on the refactoring introduced in chore: cleanup vcluster scan #30.
• vcluster sync #28: The main PR builds upon the initial vcluster sync from vcluster sync #28, refactoring kind generation and adding relationship rule logic in the same code areas.

Poem

A vcluster hops from cloud to cloud,
With new rules linking where it's found.
Kinds and keys now neatly defined,
Logging structured, errors aligned.
From GKE to EKS, the map is clear—
Relationships formed, the path sincere.
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a5f3e7f and 6fced8c.

📒 Files selected for processing (3)

• cmd/ctrlc/root/sync/kubernetes/vcluster.go (6 hunks)
• internal/api/resource_provider.go (1 hunks)
• internal/kinds/db.go (2 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.