Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Clarify TypeScript tutorial & add example #770

Merged
merged 10 commits into from
Sep 17, 2022
Merged

docs: Clarify TypeScript tutorial & add example #770

merged 10 commits into from
Sep 17, 2022

Conversation

jmyrland
Copy link
Collaborator

@jmyrland jmyrland commented Sep 16, 2022 •
edited
Loading

Attempt to clarify the TS docs & adds a simple todo app example.

closes #763, #612
related to #699

@jmyrland
Clarify TS docs
1f4a440 
Attempt to clarify the TS docs.

closes #763
@jmyrland jmyrland mentioned this pull request Sep 16, 2022
Closed
@ctrlplusb ctrlplusb changed the title Clarify TS docs docs: Clarify TypeScript tutorial Sep 16, 2022
@jmyrland
Copy link
Collaborator Author

jmyrland commented Sep 16, 2022 •
edited
Loading

Added a simple todo app example & updated the TS docs to be based on a "flat" store.

todo-app

jmyrland
jmyrland commented Sep 16, 2022
View reviewed changes
examples/simple-todo/src/store/model.ts
Comment on lines +51 to +52
onTodosChanged: thunkOn(
(actions) => [actions.addTodo, actions.toggleTodo],
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once effectOn is stable - we could swap it out if we'd want to

@jmyrland jmyrland changed the title docs: Clarify TypeScript tutorial docs: Clarify TypeScript tutorial & add example Sep 16, 2022
jmyrland
jmyrland commented Sep 16, 2022
View reviewed changes
examples/simple-todo/package.json Outdated
Comment on lines 14 to 16
"easy-peasy": "5.1.0-alpha.3",
"react": "^18.2.0",
"react-dom": "^18.2.0"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also verified 🎉

@ctrlplusb
Copy link
Owner

Rad! Let's get this updated with latest from master and then merge.

I'm going to start working on GitHub actions for master pushes so that docs and code coverage etc gets auto run/deployed.

@vercel
Copy link

vercel bot commented Sep 17, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
easy-peasy ✅ Ready (Inspect) Visit Preview Sep 17, 2022 at 9:47AM (UTC)

ctrlplusb
ctrlplusb approved these changes Sep 17, 2022
View reviewed changes
Copy link
Owner

@ctrlplusb ctrlplusb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Champion! ♥️

@ctrlplusb ctrlplusb merged commit d749104 into master Sep 17, 2022
@ctrlplusb ctrlplusb deleted the docs/clarify-ts-example branch September 17, 2022 10:25
@jmyrland jmyrland mentioned this pull request Sep 19, 2022
Closed
@apuatcfbd
Copy link

Please also include how we can build up a distributed state (across files) in typescript. For example, cart, products, user slices are in different file.

@jmyrland
Copy link
Collaborator Author

Please also include how we can build up a distributed state (across files) in typescript. For example, cart, products, user slices are in different file.

This would be a great example - thanks for the input 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctrlplusb ctrlplusb ctrlplusb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation make no sense. (Typescript)
3 participants
@jmyrland @ctrlplusb @apuatcfbd