New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set ctrlp buffer's filetype #316

Merged
merged 1 commit into from Jun 11, 2018

Conversation

Projects
None yet
4 participants
@HerringtonDarkholme
Copy link

HerringtonDarkholme commented Oct 21, 2016

Dear ctrlp developer. I think setting ctrlp's buffer filetype might help users and other developers find easier way to customize ctrlp. For example, adding sytnax highlight to text elements that not provided by ctrlp's API is easier.

A usage is vim-devicon. Icon highlight can be added ad poc easily by just adding syntax/ctrlp.vim to runtime path.

screenshot from 2016-10-21 20-41-53

@ryanoasis ryanoasis referenced this pull request Apr 21, 2017

Open

colorize ctrlP icons #201

@tacahiroy

This comment has been minimized.

Copy link
Member

tacahiroy commented Jun 17, 2017

This sounds like useful for some use case and no drawbacks if we add this.
@mattn What do you think?

@alvinlee001

This comment has been minimized.

Copy link

alvinlee001 commented Jun 5, 2018

could this be merged? i really like to have this feature

@HerringtonDarkholme

This comment has been minimized.

Copy link

HerringtonDarkholme commented Jun 5, 2018

@tacahiroy @mattn Would you like to give this a look?

@mattn

This comment has been minimized.

Copy link

mattn commented Jun 8, 2018

Sounds good to me. But I want to be careful since kien/ctrlp did not use filetype even if it such change was requested.

@mattn

This comment has been minimized.

Copy link

mattn commented Jun 11, 2018

Finally, I'll merge this. But probably, this make CtrlP heavily or slowly since user will be possible to extend events.

@mattn mattn merged commit 6ffa5bb into ctrlpvim:master Jun 11, 2018

@HerringtonDarkholme

This comment has been minimized.

Copy link

HerringtonDarkholme commented Jun 11, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment