Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GMP mercurial host blocks certain IP ranges #391

Open
dblane-digicatapult opened this issue Mar 8, 2024 · 2 comments
Open

GMP mercurial host blocks certain IP ranges #391

dblane-digicatapult opened this issue Mar 8, 2024 · 2 comments

Comments

@dblane-digicatapult
Copy link

in cheribuild/pycheribuild/projects/cross/gmp.py we are using MercurialRepository with a repository of repository = MercurialRepository("https://gmplib.org/repo/gmp") However, the host for this (quite rightly) blocks certain large IP ranges, namely all of Azure and Github Actions runners, this causes any build that has GMP as a dependency to fail.

There is a well maintained mirror hosted on github at https://github.com/gmp-mirror/gmp which maintains the entire hg repositories commit history and contains some additional branches.

Would it be possible for us to switch to using the mirror instead?

@qwattash
Copy link
Contributor

qwattash commented Mar 8, 2024

I don't have anything against it. The commits appear to be in sync on the main branch.

@jrtc27
Copy link
Member

jrtc27 commented Mar 8, 2024

My recollection was that either such a git mirror didn’t exist or it was outdated back when I added gmp as a mercurial repo. Using git is certainly easier (the MercurialRepository implementation is quite crude and easy to break if you make local changes, but good enough for our use case) provided we know that we can rely on the mirror going forwards. There’s also the issue of needing to convert the user’s checkout from mercurial to git, which I don’t think needs to be any more complex than informing the user (in the same way as we do for switching branches) and then wiping the directory if it’s got a .hg subdirectory, as I highly doubt users have local changes (if they do they should save them elsewhere before saying yes to the prompt).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants