Adding ODT example to storybook and fixing variorum bugs #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds ODT as a test case for variorum and polygonal shape features
Improved variorum navigation and fixed folio name collision bug
Added storybook workflow
Added storybook back
|
Update: Now also addresses Issue #118 by removing the blue highlighting from the "current folio" in grid mode. |
Added touchscreen functionality for resizing
|
Further update: Now includes a fix to the resizing functionality of the split pane view so that it now works with touchscreen devices as well as mouse clicks. |
Improving the handling of component state changes
…oncrafter into RB-state-change-fix
…oftware/editioncrafter into RB-state-change-fix
Improve handling of component props updating
|
Further update: Now also includes a trigger to reload the document data in the case that the component props change without the user navigating to a new page. (See PR #123 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR
folioIDwere not being stored properly in the component state: when in variorum mode, folios are now stored internally with the ID[documentID]_[folioID]to avoid collisions;viewportStatefunction to track the associated document of the currently selected folio, so that if you navigate back to the grid view from a folio in variorum mode, the document that folio came from will be automatically selected;