Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: notStartsWith/notEndsWith filters support #5579

Merged
merged 1 commit into from Nov 7, 2022

Conversation

buntarb
Copy link
Contributor

@buntarb buntarb commented Nov 7, 2022

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@buntarb buntarb requested review from a team as code owners November 7, 2022 21:15
@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Base: 40.55% // Head: 40.57% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (c45f65a) compared to base (09ceffb).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5579      +/-   ##
==========================================
+ Coverage   40.55%   40.57%   +0.01%     
==========================================
  Files         144      144              
  Lines       19339    19343       +4     
  Branches     4901     4901              
==========================================
+ Hits         7843     7848       +5     
+ Misses      11191    11190       -1     
  Partials      305      305              
Flag Coverage Δ
cube-backend 40.57% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/cubejs-api-gateway/src/query.js 74.59% <ø> (ø)
...s/cubejs-schema-compiler/src/adapter/BaseFilter.js 54.73% <0.00%> (-1.18%) ⬇️
...es/cubejs-schema-compiler/src/adapter/BaseQuery.js 70.80% <0.00%> (+0.38%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@buntarb buntarb merged commit 8765833 into master Nov 7, 2022
@buntarb buntarb deleted the features/notStartsWith_notEndsWith_filters branch November 7, 2022 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant