Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

respect ungrouped parameter #684

Merged
merged 1 commit into from Jun 3, 2020
Merged

respect ungrouped parameter #684

merged 1 commit into from Jun 3, 2020

Conversation

gauravlanjekar
Copy link
Contributor

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

[For example #683]

Description of Changes Made (if issue reference is not provided)

[Description goes here]

@codecov-commenter
Copy link

Codecov Report

Merging #684 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #684   +/-   ##
=======================================
  Coverage   80.71%   80.71%           
=======================================
  Files          40       40           
  Lines        3319     3319           
=======================================
  Hits         2679     2679           
  Misses        640      640           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28dc4de...5549c5b. Read the comment docs.

@paveltiunov
Copy link
Member

@gauravlanjekar Hey Gaurav! Thanks for fixing this one!

@paveltiunov paveltiunov merged commit 27d0d49 into cube-js:master Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants