Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Presto offset with limit are in the wrong order #988

Closed
Ulimo opened this issue Aug 12, 2020 · 1 comment · Fixed by #1135
Closed

Presto offset with limit are in the wrong order #988

Ulimo opened this issue Aug 12, 2020 · 1 comment · Fixed by #1135
Assignees
@ovr
Labels
bug Something isn't working help wanted Community contributions are welcome.

Comments

@Ulimo
Copy link

Ulimo commented Aug 12, 2020

Describe the bug
If you try to use offset with at least the presto connector you gain a user error from presto.

The SQL statement is: "select ... from ... limit ? offset ?"

To Reproduce
Steps to reproduce the behavior:
Send in any query that uses the offset with the presto adapter.

Expected behavior
A sql statement should generate that looks like: "select ... from ... offset ? limit ?".

Version:
0.19.61

Additional context
I looked at the code and you should only need to change place of the offset and the limit. I had some troubles compiling locally so I cant send in a PR my self at the moment.
@paveltiunov
Copy link
Member

Hey @Ulimo ! Thanks for posting this one!

@paveltiunov paveltiunov added bug Something isn't working help wanted Community contributions are welcome. labels Aug 15, 2020
@paveltiunov paveltiunov mentioned this issue Sep 17, 2020
Closed
@ovr ovr mentioned this issue Sep 21, 2020
Merged
4 tasks
ovr added a commit that referenced this issue Sep 23, 2020
@ovr
Fix: PrestodbQuery - overide groupByDimensionLimit to right OFFSET LI…
34c99e6 
…MIT order, #988
ovr added a commit that referenced this issue Sep 23, 2020
@ovr
Fix: PrestodbQuery - overide groupByDimensionLimit to right OFFSET LI…
1d309da 
…MIT order, #988
@ovr ovr mentioned this issue Sep 23, 2020
Merged
4 tasks
ovr added a commit that referenced this issue Sep 23, 2020
@ovr
test: Add test for #988
d964e55
ovr added a commit that referenced this issue Sep 23, 2020
@ovr
test: Add test for #988
ffd869e
paveltiunov pushed a commit that referenced this issue Sep 23, 2020
@ovr
fix(@cubejs-backend/prestodb-driver): Wrong OFFSET/LIMIT order (#1135)
3b94b2c 
* Feature: Simplify tests by async/await

* Fix: PrestodbQuery - overide groupByDimensionLimit to right OFFSET LIMIT order, #988

* test: Add test for #988

Fixes #988
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ovr ovr

Labels
bug Something isn't working help wanted Community contributions are welcome.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #988 PrestoDB wrong OFFSET/LIMIT order cube-js/cube
3 participants
@paveltiunov @ovr @Ulimo