Skip to content

Conversation

@KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Nov 27, 2025

  • openapi spec: add timezone to request
  • pass query timezone through cubesql into cube.js

Check List

  • Tests have been run in packages where changes have been made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@github-actions github-actions bot added rust Pull requests that update Rust code javascript Pull requests that update Javascript code labels Nov 27, 2025
@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

❌ Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.93%. Comparing base (bfe951c) to head (b7ba867).
⚠️ Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
packages/cubejs-api-gateway/src/sql-server.ts 0.00% 1 Missing ⚠️
rust/cubesql/cubesql/src/compile/builder.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #10189       +/-   ##
===========================================
+ Coverage   54.62%   77.93%   +23.30%     
===========================================
  Files         214      461      +247     
  Lines       17012    91253    +74241     
  Branches     3475     3476        +1     
===========================================
+ Hits         9293    71114    +61821     
- Misses       7218    19639    +12421     
+ Partials      501      500        -1     
Flag Coverage Δ
cube-backend 54.62% <50.00%> (+<0.01%) ⬆️
cubesql 83.27% <90.90%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KSDaemon KSDaemon marked this pull request as ready for review November 27, 2025 14:38
@KSDaemon KSDaemon requested review from a team as code owners November 27, 2025 14:38
@KSDaemon KSDaemon merged commit 499ddc6 into master Nov 28, 2025
121 of 123 checks passed
@KSDaemon KSDaemon deleted the feat/tz-in-cubesql branch November 28, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update Javascript code rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants