Skip to content

Conversation

@ovr
Copy link
Member

@ovr ovr commented Dec 1, 2025

image

@github-actions github-actions bot added client:core Issues relating to the JavaScript client SDK javascript Pull requests that update Javascript code labels Dec 1, 2025
@github-actions github-actions bot added the rust Pull requests that update Rust code label Dec 1, 2025
@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

❌ Patch coverage is 63.63636% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.93%. Comparing base (c6eca9c) to head (c3d38de).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...ema-compiler/src/compiler/CubeToMetaTransformer.ts 25.00% 6 Missing ⚠️
...ient/src/models/v1_cube_meta_custom_time_format.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10204      +/-   ##
==========================================
- Coverage   77.94%   77.93%   -0.01%     
==========================================
  Files         461      464       +3     
  Lines       91235    91276      +41     
  Branches     3470     3480      +10     
==========================================
+ Hits        71117    71140      +23     
- Misses      19622    19640      +18     
  Partials      496      496              
Flag Coverage Δ
cube-backend 54.72% <77.77%> (+0.04%) ⬆️
cubesql 83.26% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ovr ovr marked this pull request as ready for review December 1, 2025 12:04
@ovr ovr requested review from a team as code owners December 1, 2025 12:04
@ovr ovr changed the title feat: Support defining custom date formatting for time dimensions feat: Support custom date formatting for time dimensions Dec 1, 2025
Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure about STRPTIME_SPECIFIERS? I was under the impression, that it should be STRFTIME_SPECIFIERS. Can't figure out why P?) F looks natural as it is strFtime.

Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides that naming, everything LGTM! 👍🏻

@ovr ovr force-pushed the feat/custom-date-formatting branch 2 times, most recently from 1ff5c26 to b1bca93 Compare December 2, 2025 12:01
@ovr ovr force-pushed the feat/custom-date-formatting branch from b1bca93 to c3d38de Compare December 2, 2025 12:13
@ovr ovr merged commit 8e18659 into master Dec 2, 2025
84 of 86 checks passed
@ovr ovr deleted the feat/custom-date-formatting branch December 2, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client:core Issues relating to the JavaScript client SDK javascript Pull requests that update Javascript code rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants