-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat: Support custom date formatting for time dimensions #10204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10204 +/- ##
==========================================
- Coverage 77.94% 77.93% -0.01%
==========================================
Files 461 464 +3
Lines 91235 91276 +41
Branches 3470 3480 +10
==========================================
+ Hits 71117 71140 +23
- Misses 19622 19640 +18
Partials 496 496
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
KSDaemon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure about STRPTIME_SPECIFIERS? I was under the impression, that it should be STRFTIME_SPECIFIERS. Can't figure out why P?) F looks natural as it is strFtime.
KSDaemon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides that naming, everything LGTM! 👍🏻
1ff5c26 to
b1bca93
Compare
b1bca93 to
c3d38de
Compare
Uh oh!
There was an error while loading. Please reload this page.