Skip to content

Conversation

@KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Dec 1, 2025

Athena and Trino don't require old prestodb hacks for time zone conversion.

Check List

  • Tests have been run in packages where changes have been made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@github-actions github-actions bot added the javascript Pull requests that update Javascript code label Dec 1, 2025
@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.68%. Comparing base (c6eca9c) to head (8c03220).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
.../cubejs-schema-compiler/src/adapter/AthenaQuery.ts 66.66% 1 Missing ⚠️
...s/cubejs-schema-compiler/src/adapter/TrinoQuery.ts 66.66% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (c6eca9c) and HEAD (8c03220). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (c6eca9c) HEAD (8c03220)
cubesql 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #10207       +/-   ##
===========================================
- Coverage   77.94%   54.68%   -23.27%     
===========================================
  Files         461      219      -242     
  Lines       91235    17009    -74226     
  Branches     3470     3472        +2     
===========================================
- Hits        71117     9302    -61815     
+ Misses      19622     7211    -12411     
  Partials      496      496               
Flag Coverage Δ
cube-backend 54.68% <75.00%> (+<0.01%) ⬆️
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KSDaemon KSDaemon force-pushed the fix/tz-presto-athena branch from 468d9a1 to 8c03220 Compare December 2, 2025 09:36
@KSDaemon KSDaemon marked this pull request as ready for review December 2, 2025 10:02
@KSDaemon KSDaemon requested a review from a team as a code owner December 2, 2025 10:02
@KSDaemon KSDaemon merged commit 32d50a5 into master Dec 2, 2025
109 of 110 checks passed
@KSDaemon KSDaemon deleted the fix/tz-presto-athena branch December 2, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants