React QueryBuilder show dry-run errors #2262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr:community
Codecov Report
@@ Coverage Diff @@
## master #2262 +/- ##
==========================================
- Coverage 55.75% 55.65% -0.10%
==========================================
Files 118 118
Lines 8690 8648 -42
Branches 1891 1888 -3
==========================================
- Hits 4845 4813 -32
+ Misses 3466 3456 -10
Partials 379 379
Continue to review full report at Codecov.
|
4 tasks
vasilev-alex
approved these changes
Mar 5, 2021
vasilev-alex
added a commit
that referenced
this pull request
Mar 23, 2021
…wing dryRun errors (#2262) Co-authored-by: Peter Steffey <psteffey@directdefense.com> Co-authored-by: Alex.V <vaspiring@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Broken off of #2196
In QueryBuilder, I noticed that if dryRun failed, the error was logged to the console but not shown to the user. Instead of ignoring and letting the query call report the same error, I changed it so that dryRun errors are reported to the rendered function in the error prop. This is mostly useful when
wrapWithQueryRendereris false, as when it is true, the QueryRenderer will produce the same error and overwrite with it's own error prop (by design).