New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(client-vue): boolean filters support #4314
Conversation
# Conflicts: # packages/cubejs-client-vue/src/QueryBuilder.js
Codecov Report
@@ Coverage Diff @@
## master #4314 +/- ##
===========================================
- Coverage 69.11% 58.95% -10.16%
===========================================
Files 240 134 -106
Lines 22836 10952 -11884
Branches 2585 2585
===========================================
- Hits 15782 6457 -9325
+ Misses 6777 4218 -2559
Partials 277 277
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
@vasilev-alex could you review this PR please ? |
Check List
Issue Reference this PR resolves
4201
Description of Changes Made (if issue reference is not provided)
Nested boolean operators in filters like the example given in the docs are not compatible with the current version of
query-builder
Vue component.I have improved the query-builder in order to take into account nested boolean operators. I have also added tests.