Skip to content

Conversation

@buntarb
Copy link
Contributor

@buntarb buntarb commented Oct 8, 2022

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@buntarb buntarb requested a review from a team as a code owner October 8, 2022 10:16
@codecov
Copy link

codecov bot commented Oct 8, 2022

Codecov Report

Base: 84.55% // Head: 60.94% // Decreases project coverage by -23.60% ⚠️

Coverage data is based on head (c6374c9) compared to base (bba50da).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5448       +/-   ##
===========================================
- Coverage   84.55%   60.94%   -23.61%     
===========================================
  Files         135      140        +5     
  Lines       21938    12030     -9908     
  Branches        0     2953     +2953     
===========================================
- Hits        18550     7332    -11218     
- Misses       3388     4395     +1007     
- Partials        0      303      +303     
Flag Coverage Δ
cube-backend 60.94% <100.00%> (?)
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/cubejs-base-driver/src/BaseDriver.ts 27.16% <100.00%> (ø)
.../cubesql/cubesql/src/sql/database_variables/mod.rs
...gine/information_schema/postgres/pg_description.rs
...engine/information_schema/postgres/pg_attribute.rs
...st/cubesql/cubesql/src/compile/rewrite/analysis.rs
rust/cubesql/pg-srv/src/pg_type.rs
rust/cubesql/cubesql/e2e/tests/utils.rs
...cubesql/cubesql/src/compile/rewrite/rules/order.rs
...src/models/v1_load_request_query_time_dimension.rs
rust/cubesql/cubesql/src/transport/service.rs
... and 266 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@buntarb buntarb merged commit ab12426 into master Oct 8, 2022
@buntarb buntarb deleted the bugfix/drivers_import_alignment branch October 8, 2022 10:40
@buntarb buntarb mentioned this pull request Oct 8, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants