Skip to content

feat(redshift-driver): optimize testConnection() with just establishing connection without real query #8847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2024
Merged

feat(redshift-driver): optimize testConnection() with just establishing connection without real query #8847

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions packages/cubejs-redshift-driver/src/RedshiftDriver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,16 @@ export class RedshiftDriver extends PostgresDriver<RedshiftDriverConfiguration>
}
}

/**
* AWS Redshift doesn't have any special connection check.
* And querying even system tables is billed.
* @override
*/
public async testConnection() {
const conn = await this.pool.connect();
conn.release();
}

public override async stream(
query: string,
values: unknown[],
Expand Down Expand Up @@ -287,8 +297,7 @@ export class RedshiftDriver extends PostgresDriver<RedshiftDriverConfiguration>
};
} finally {
conn.removeAllListeners('notice');

await conn.release();
conn.release();
}
}

Expand Down
Loading