fix(clickhouse-driver): Support overriding Username & Password from Driver Config #9085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add possibility to override username and password from driver config
github-actions
bot
added
the
pr:community
KSDaemon
changed the title
Member
|
Hey @danieljaniga! Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to override the username and password from the driver configuration. Currently, when using multiple data sources for different tenants (Multitenancy vs Multiple Data Sources) it is not possible to use the username and password defined in the
ClickHouseDriverconfig instead of the default ENV variables CUBEJS_DB_USER, CUBEJS_DB_PASSCheck List