Skip to content

Conversation

@mcheshkov
Copy link
Contributor

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made (if issue reference is not provided)

Without this queries with duplicated aggregations on top of __user filter can execute with unnecessary post-processing, or, in aggregate-sort-limit case, even can fall back to SQL pushdown.
For now, only __user filters are enabled, others will be done later

For now, only __user filters are enabled, others will be done later
@codecov
Copy link

codecov bot commented Mar 31, 2025

Codecov Report

Attention: Patch coverage is 98.78049% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.74%. Comparing base (dc93e40) to head (2f7a105).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
rust/cubesql/cubesql/src/compile/test/utils.rs 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9409      +/-   ##
==========================================
+ Coverage   83.72%   83.74%   +0.01%     
==========================================
  Files         229      229              
  Lines       82614    82694      +80     
==========================================
+ Hits        69172    69248      +76     
- Misses      13442    13446       +4     
Flag Coverage Δ
cubesql 83.74% <98.78%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcheshkov mcheshkov marked this pull request as ready for review April 1, 2025 11:57
@mcheshkov mcheshkov requested a review from a team as a code owner April 1, 2025 11:57
@mcheshkov mcheshkov merged commit 351ac7a into master Apr 1, 2025
76 checks passed
@mcheshkov mcheshkov deleted the missing-flatten-double-agg-with-rls branch April 1, 2025 12:33
marianore-muttdata pushed a commit to MuttData/cube that referenced this pull request Jun 17, 2025
…own (cube-js#9409)

Without this queries with duplicated aggregations on top of `__user` filter can execute with unnecessary post-processing, or, in aggregate-sort-limit case, even can fall back to SQL pushdown.
For now, only `__user` filters are enabled, others will be done later.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants