Skip to content

Conversation

@MazterQyou
Copy link
Member

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made

This PR changes the behavior of SQL push down generation for DATE_TRUNC expressions, generating a member expression with granularity rather than DATE_TRUNC SQL equivalent. Related tests are adjusted.

@MazterQyou MazterQyou requested a review from a team as a code owner May 18, 2025 21:51
@codecov
Copy link

codecov bot commented May 18, 2025

Codecov Report

Attention: Patch coverage is 91.42857% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.11%. Comparing base (2e47147) to head (3388b52).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...t/cubesql/cubesql/src/compile/engine/df/wrapper.rs 90.62% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #9583       +/-   ##
===========================================
+ Coverage        0   84.11%   +84.11%     
===========================================
  Files           0      230      +230     
  Lines           0    84440    +84440     
===========================================
+ Hits            0    71023    +71023     
- Misses          0    13417    +13417     
Flag Coverage Δ
cubesql 84.11% <91.42%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

…ns with granularity

Signed-off-by: Alex Qyoun-ae <4062971+MazterQyou@users.noreply.github.com>
@MazterQyou MazterQyou force-pushed the cubesql/push-down-date-trunc-as-member branch from e688793 to 3388b52 Compare May 19, 2025 14:07
@MazterQyou MazterQyou merged commit b9c97cd into master May 19, 2025
74 checks passed
@MazterQyou MazterQyou deleted the cubesql/push-down-date-trunc-as-member branch May 19, 2025 15:45
marianore-muttdata pushed a commit to MuttData/cube that referenced this pull request Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants