Skip to content

Conversation

@srh
Copy link
Contributor

@srh srh commented May 20, 2025

…h_metadata on Windows

This is to replace #9463 because it also avoids affecting any paths with backslashes in them on Linux.

@oldoldman

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

Closes #9460
Closes #9463

@srh srh requested a review from a team as a code owner May 20, 2025 21:36
@srh srh force-pushed the local_dir_backslash branch from 02ef7b7 to 2278fe3 Compare May 20, 2025 21:48
Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 LGTM!

@srh srh merged commit 7b4e4ad into master May 21, 2025
51 checks passed
@srh srh deleted the local_dir_backslash branch May 21, 2025 13:22
marianore-muttdata pushed a commit to MuttData/cube that referenced this pull request Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LocalDirRemoteFs::list_recursive is not portable on Windows

4 participants