Skip to content

Conversation

@KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented May 22, 2025

This PR fixes incorrect sql generation for queries with rolling windows coming from SQL API with member expressions instead of time dimensions.

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet

@KSDaemon KSDaemon marked this pull request as ready for review May 22, 2025 11:55
@KSDaemon KSDaemon requested review from a team as code owners May 22, 2025 11:55
@MazterQyou MazterQyou changed the title fix(schema-compiler): Fix rolling window queries with expressions from SQP API fix(schema-compiler): Fix rolling window queries with expressions from SQL API May 22, 2025
@KSDaemon KSDaemon force-pushed the fix/nulls-in-td-from-sqlapi branch from 8123081 to ccfb270 Compare May 22, 2025 14:10
@MazterQyou MazterQyou merged commit 43f47d8 into master May 22, 2025
62 checks passed
@MazterQyou MazterQyou deleted the fix/nulls-in-td-from-sqlapi branch May 22, 2025 14:55
marianore-muttdata pushed a commit to MuttData/cube that referenced this pull request Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants