From d49fbe7526a6e946bf54eff7fe83ba0b729d9ce0 Mon Sep 17 00:00:00 2001 From: Jakub Martin Date: Mon, 7 Aug 2023 15:05:40 +0200 Subject: [PATCH] Add todo. --- arrowexec/nodes/group_by.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arrowexec/nodes/group_by.go b/arrowexec/nodes/group_by.go index fb05e235..00ba8d7b 100644 --- a/arrowexec/nodes/group_by.go +++ b/arrowexec/nodes/group_by.go @@ -251,7 +251,7 @@ func (key *KeyInt) GetBatch(length int, offset int) arrow.Array { } type KeyString struct { - // TODO: Refactor to use custom array data. + // TODO: Use a LargeStringArray, instead of a StringArray. // We use a custom set of buffers, rather than using the builder, because accessing elements of the builder is slow. offsetsData *memory.Buffer // TODO: Release these buffers at some point. offsetsState []int32 // This uses the above data as the storage underneath.