New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structured Data is incomplete and needs improving #1733

Closed
abrookbanks opened this Issue Sep 15, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@abrookbanks
Member

abrookbanks commented Sep 15, 2017

Review products, breadcrumbs, company info, search etc..

@havenswift-hosting

This comment has been minimized.

Show comment
Hide comment
@havenswift-hosting

havenswift-hosting Sep 15, 2017

Is there really a need when we have a perfectly good plugin that works well - surely time would be better spent adding features that cannot (easily) be done with plugins or have been outstanding for a while ?

havenswift-hosting commented Sep 15, 2017

Is there really a need when we have a perfectly good plugin that works well - surely time would be better spent adding features that cannot (easily) be done with plugins or have been outstanding for a while ?

@abrookbanks

This comment has been minimized.

Show comment
Hide comment
@abrookbanks

abrookbanks Sep 15, 2017

Member

Yes for a few reasons;

  1. CubeCart already had this functionality but it was fairly limited.
  2. As you have pointed out its easy. This took all of about 30 mins.
  3. The demand for this has increased recently. If we service it out the box we may have more happy users.

Sorry if I'm stepping on your toes here but I want to enhance it further.

Member

abrookbanks commented Sep 15, 2017

Yes for a few reasons;

  1. CubeCart already had this functionality but it was fairly limited.
  2. As you have pointed out its easy. This took all of about 30 mins.
  3. The demand for this has increased recently. If we service it out the box we may have more happy users.

Sorry if I'm stepping on your toes here but I want to enhance it further.

abrookbanks added a commit that referenced this issue Sep 15, 2017

@havenswift-hosting

This comment has been minimized.

Show comment
Hide comment
@havenswift-hosting

havenswift-hosting Sep 15, 2017

Doesnt really encourage the very limited number of developers working with CubeCart to develop plugins
does it ! In addition, it deprives you of revenue via the marketplace as that is one plugin that will not sell again

havenswift-hosting commented Sep 15, 2017

Doesnt really encourage the very limited number of developers working with CubeCart to develop plugins
does it ! In addition, it deprives you of revenue via the marketplace as that is one plugin that will not sell again

@abrookbanks

This comment has been minimized.

Show comment
Hide comment
@abrookbanks

abrookbanks Sep 15, 2017

Member

This was a basic feature long before you created that extension and version 6 was developed with the intention of having this integrated as standard. Basic structured data has been in version 6 since first launch.

The snippet of code below is from the content.product.php file in 6.0.0.

<div itemscope itemtype="http://schema.org/Product">
   <form action="{$VAL_SELF}" method="post" class="add_to_basket">
      <div class="row">
         <div class="small-12 columns">
            <h1 itemprop="name">{$PRODUCT.name}</h1>
         </div>
      </div>
Member

abrookbanks commented Sep 15, 2017

This was a basic feature long before you created that extension and version 6 was developed with the intention of having this integrated as standard. Basic structured data has been in version 6 since first launch.

The snippet of code below is from the content.product.php file in 6.0.0.

<div itemscope itemtype="http://schema.org/Product">
   <form action="{$VAL_SELF}" method="post" class="add_to_basket">
      <div class="row">
         <div class="small-12 columns">
            <h1 itemprop="name">{$PRODUCT.name}</h1>
         </div>
      </div>

@abrookbanks abrookbanks added bug and removed feature request labels Sep 15, 2017

@abrookbanks abrookbanks changed the title from Structured Data needs improving to Structured Data is incomplete and needs improving Sep 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment