Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authorize.net Testing the Result #1741

Closed
bhsmither opened this issue Sep 26, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@bhsmither
Copy link
Contributor

commented Sep 26, 2017

The Authorize.net module, gateway.class.php, line 202 (new to version 1.1.2):

Earlier, the $resp from $request->send() is presumably a string, that is exploded to presumably an array of strings.

Following that, tests use the type-juggled comparison operator against integers. No problem there.

However, the new code uses a strict comparison operator !== that will always fail (evaluates to true), as it is comparing a presumed string against an integer.

Suggest changing:

if($results[0] !== 1) {

to

if($results[0] != 1) {

See:
https://forums.cubecart.com/topic/52794-authorizenet-pending-verification-transactions/?tab=comments#comment-229064

If the Authorize API docs say that $results[0] being a '4' is a proper result for "Authorize Only", the module needs to be coded to deal with that as something other than an error, with the order being Pending.

@abrookbanks abrookbanks self-assigned this Sep 27, 2017

@abrookbanks abrookbanks added the bug label Sep 27, 2017

@abrookbanks

This comment has been minimized.

Copy link
Member

commented Sep 27, 2017

Released 1.1.3. :) Thanks.

I haven't tested this but trust your findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.