New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customised print order template to be customised without upgrade overwrite #1904

Closed
abrookbanks opened this Issue Mar 14, 2018 · 5 comments

Comments

Projects
None yet
2 participants
@abrookbanks
Member

abrookbanks commented Mar 14, 2018

As above. A WYSIWYG editor would be good.

@abrookbanks abrookbanks added this to the 6.2.0 milestone Mar 14, 2018

@abrookbanks abrookbanks self-assigned this Mar 14, 2018

abrookbanks added a commit that referenced this issue Mar 14, 2018

abrookbanks added a commit that referenced this issue Mar 14, 2018

abrookbanks added a commit that referenced this issue Mar 14, 2018

abrookbanks added a commit that referenced this issue Mar 14, 2018

@abrookbanks

This comment has been minimized.

Member

abrookbanks commented Mar 14, 2018

screen shot 2018-03-14 at 13 55 16

abrookbanks added a commit that referenced this issue Mar 15, 2018

@bhsmither

This comment has been minimized.

Contributor

bhsmither commented May 23, 2018

Did you mean to include the textarea for the email contents editor? See:
059e8cf#diff-ec3350c6cbe91f80d4c935e2187021ea

Where the contents sit inside the template, the template should have the fck-full attribute, but not the contents editor.

@abrookbanks

This comment has been minimized.

Member

abrookbanks commented Jun 7, 2018

No I don't think I did. I just removed the "textbox" class.

See: 7a437ab

I think that's what you meant. Thanks.

@bhsmither

This comment has been minimized.

Contributor

bhsmither commented Jun 7, 2018

No, I disagree with this change.

The fck-full attribute causes CKEditor to create a complete HTML document (has <html>, <head>, and <body> tags. These tags are not wanted in an email content template.

abrookbanks added a commit that referenced this issue Jun 8, 2018

@abrookbanks

This comment has been minimized.

Member

abrookbanks commented Jun 8, 2018

Gotcha. Sorry for the confusion. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment