Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Class Instantiation #2252

Closed
bhsmither opened this Issue Mar 6, 2019 · 4 comments

Comments

Projects
None yet
3 participants
@bhsmither
Copy link
Contributor

bhsmither commented Mar 6, 2019

Just guessing at this point... (CC623)

In filemanager.class.php, near line 899, Ctalaogue is instantiated with

new Catalogue();

However, now that Catalogue has a non-imaginary

final protected function __construct()

I believe the new instantiation won't work. (Your testing may have shown otherwise.)

I think the following is now necessary:

$catalogue = $GLOBALS['catalogue']->getInstance();

I think the reason it worked in CC622 and earlier is because the class was presumed to have an inherited public magic __construct() method.

@havenswift-hosting

This comment has been minimized.

Copy link

havenswift-hosting commented Mar 6, 2019

I can confirm that this fixes this issue in 6.2.3

@abrookbanks

This comment has been minimized.

Copy link
Member

abrookbanks commented Mar 6, 2019

What does this fix?

@bhsmither

This comment has been minimized.

Copy link
Contributor Author

bhsmither commented Mar 6, 2019

Either or both, in admin, FileManager, a white screen (aka 500 ISE - PHP Fatal Error), or a missing list of images on the admin's Add/Edit Product, Images tab, Image FilePicker.

@abrookbanks

This comment has been minimized.

Copy link
Member

abrookbanks commented Mar 6, 2019

Thanks for this. Big one so we need a new release. Damn it.

@abrookbanks abrookbanks self-assigned this Mar 6, 2019

@abrookbanks abrookbanks added this to the 6.2.4 milestone Mar 6, 2019

@abrookbanks abrookbanks closed this Mar 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.