Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request class ignores server response code and relies on a data response #2418

Closed
abrookbanks opened this issue Nov 6, 2019 · 2 comments
Assignees
Milestone

Comments

@abrookbanks
Copy link
Member

@abrookbanks abrookbanks commented Nov 6, 2019

Sometimes a server can respond with just a code to save network resources. A patch request is a good example.

e.g. 204 No Content

Right now the request class will assume failure if no response is received.

@abrookbanks abrookbanks added this to the 6.2.8 milestone Nov 6, 2019
@abrookbanks abrookbanks self-assigned this Nov 6, 2019
@abrookbanks abrookbanks changed the title Request class ignores server response code and relies on a response Request class ignores server response code and relies on a data response Nov 6, 2019
@abrookbanks

This comment has been minimized.

Copy link
Member Author

@abrookbanks abrookbanks commented Nov 6, 2019

Following on the response code must be logged and request method i.e. curl/fsock

@abrookbanks

This comment has been minimized.

Copy link
Member Author

@abrookbanks abrookbanks commented Nov 6, 2019

This feature is required for the new PayPal Commerce integration which us currently in build.
e.g. https://developer.paypal.com/docs/api/orders/v2/#orders_patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.