Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all shopping pages are recognized #34

Closed
CubeOfCheese opened this issue May 29, 2020 · 6 comments
Closed

Not all shopping pages are recognized #34

CubeOfCheese opened this issue May 29, 2020 · 6 comments
Assignees

Comments

@CubeOfCheese
Copy link
Owner

Need to improve shopping page recognition algorithm.
Examples of pages not recognized:
https://shop.nordstrom.com/
https://usa.jmkride.com/collections
https://www.fashionnova.com/
https://www.bestbuy.com/
https://www.target.com/

@lindaicing
Copy link
Collaborator

Screen Shot 2020-05-29 at 1 40 31 PM

There seems to be lots of errors involving JQuery

@CubeOfCheese
Copy link
Owner Author

Since there are so many errors for various parts of things fundamental to jquery, my first guess is that jquery isn't being loaded as a dependency. Like the library isn't included. I don't know jquery so I can't help too much, but hopefully this is a good place to start

@lindaicing
Copy link
Collaborator

I think the font also isn't being loaded properly. We can probably keep them in for now and if we don't use them later on (meaning we don't write any code using jQuery) we can remove it.

@CubeOfCheese
Copy link
Owner Author

product-card
shopify-section
The second one especially should help recognize a lot more shopping pages

@lindaicing
Copy link
Collaborator

product-card
shopify-section
The second one especially should help recognize a lot more shopping pages

Awesome! Adding to the array now

@CubeOfCheese
Copy link
Owner Author

Too broad and ongoing. More of a general goal than an issue/task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants