New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For items that can be placed in a TNT block #4237

Open
gregchu1 opened this Issue Jun 7, 2018 · 3 comments

Comments

Projects
None yet
4 participants
@gregchu1
Copy link

gregchu1 commented Jun 7, 2018

Client version: 1.12.2
Server OS: Linux
Commit id: b9fdaf8

Hi. I have a question about items that can be placed in a TNT block.
I thought the buttons, levers and torches could be placed on the side of the TNT block.
But on the cuberite server, I could not put anything on the side of the TNT block.
Even these items could not be placed on top of block. I thought I could not put anything in the
TNT block directly, but the pressure plate could be placed on the TNT block.
I can not put all other items, but it did not seem to be normal that I could only put pressure plates.
Was this behavior intended?

Expected behavior (On a regular server)

default

Actual behavior (Server opened with Cuberite)

cuberite

@Pokechu22

This comment has been minimized.

Copy link
Contributor

Pokechu22 commented Jun 7, 2018

I didn't know that that worked in vanilla, I think that must have changed somewhat recently... hm.

@gregchu1

This comment has been minimized.

Copy link

gregchu1 commented Jun 7, 2018

I now know that a regular server is called a vanilla server :D
I guess it worked in the old version, but sadly I do not have a way to check it myself...

To solve this problem, I revised the code a bit by referring to #4170 and #4205, which I thought was similar.

8
(By adding the TNT block to BlockInfo.cpp as shown the picture above)
As a result, the lever and torch could be placed on the side and top of the TNT block.
(There is still the difference that a torch and pressure plate can be placed on the TNT block)

default

But I wonder if it should be the same result as the vanilla server.
This method makes it easier to deal with TNT blocks than ever before!
Actually, I wanted to handle exceptions to the TNT block to produce exactly the same result,
but that seems to be hard for me because I have little knowledge of coding :(

@changyongGuo

This comment has been minimized.

Copy link
Contributor

changyongGuo commented Jul 11, 2018

this issue is similar to issue #4239, I will create a fix for this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment