New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If trying to attach button, lever etc.. to some items side, it immediately drops #4239

Open
brother0105 opened this Issue Jun 8, 2018 · 4 comments

Comments

Projects
None yet
5 participants
@brother0105
Copy link

brother0105 commented Jun 8, 2018

Client version: 1.12.2
Server OS: Linux
Commit id:

In vanilla server, buttons, levers, torches, etc. which is not block shape can not be placed on top or side of things like torch, flowers etc.(if trying to do that, nothing happens)

But in cuberite, it is destroyed as soon as it is attached and dropped in item form. And

I think it is bug because if trying to attach torch to side of torch, nothing happens in cuberite either like vanilla server.

Expected behavior

If trying to attach some items(like button, torch, redstone torch, pressure plate etc.) to other small blocks(like torch, flowers etc.), just swinging hand and nothing happens

Actual behavior

image
image
image
image

In that pictures, that attached things were immediately changed into item and dropped

Steps to reproduce the behavior

@tigerw

This comment has been minimized.

Copy link
Member

tigerw commented Jun 30, 2018

Indeed, it seems to be a regression introduced by a recent version of Minecraft no longer checking for invalid placements clientside, which the original code (a8a45a4) assumed.

Probably would have to go through all the handlers and do the proper FullyOccupiesVoxel checks.

@tigerw

This comment has been minimized.

Copy link
Member

tigerw commented Jun 30, 2018

Originally the client also played a small animation when you tried to place something you couldn't (the hand bobbed down and up), I wonder if this has to be explicitly sent now?

@changyongGuo

This comment has been minimized.

Copy link
Contributor

changyongGuo commented Jul 11, 2018

This issue is caused by incorrect block type check in block handler method GetPlacementBlockTypeMeta, I will create a pull request to fix this.

@tympaniplayer

This comment has been minimized.

Copy link
Contributor

tympaniplayer commented Aug 12, 2018

#4255 seems to be a duplicate of this one. The same behavior is exhibited for lillypads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment