Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cChunkDesc: No check if numbers are valid #4411

Open
Seadragon91 opened this issue Oct 3, 2019 · 2 comments

Comments

@Seadragon91
Copy link
Contributor

@Seadragon91 Seadragon91 commented Oct 3, 2019

Expected behavior

Passing invalid numbers to functions of cChunkDesc should not crash the server :)

Actual behavior

Server crashes when a invalid number is passed.
Examples:

chunkDes:GetGetBiome(1, 98)
chunkDes:SetHeight(1, 355, 1)

Manual export of the affected functions, to correct this?

@madmaxoft

This comment has been minimized.

Copy link
Member

@madmaxoft madmaxoft commented Oct 4, 2019

I think this should be postponed, the cChunkDesc class might go away completely with the 1.13 rewrite.

@madmaxoft

This comment has been minimized.

Copy link
Member

@madmaxoft madmaxoft commented Oct 4, 2019

Just keep this open as a reminder that whatever class is used as the chunk generator access, must check its inputs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.