Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIDump: Check removed API symbols #4416

Open
madmaxoft opened this issue Oct 9, 2019 · 0 comments

Comments

@madmaxoft
Copy link
Member

@madmaxoft madmaxoft commented Oct 9, 2019

We currently check PRs for new undocumented API symbols. We should also check that all the previous API symbols are still present, that the PR didn't remove an API symbol by accident. For this, APIDump needs to output the list of all current symbols and be able to compare that list against an official list downloaded from web (just like the undocumented symbols). And we need to decide on a way to support actually removing API symbols when we do want to remove them - ignore the build failure in the PR, or make some special arrangements for the check to ignore specific symbols?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.