Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upThe build system should use FindLua51 to load the system lua if present #739
Comments
worktycho
added
enhancement
labels
Mar 1, 2014
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
madmaxoft
Mar 1, 2014
Member
I'm not sure how that would work on Windows in MSVC - if there's no Lua project in the solution, then MCServer won't compile against any Lua.
|
I'm not sure how that would work on Windows in MSVC - if there's no Lua project in the solution, then MCServer won't compile against any Lua. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
worktycho
Mar 1, 2014
Member
It sets a variable to the path of the lua libraries. Cmake and MSVC both support linking in external libraries. we just have to import the system lua library as the lua target the cmake will sort out the MSVC project to handle it.
|
It sets a variable to the path of the lua libraries. Cmake and MSVC both support linking in external libraries. we just have to import the system lua library as the lua target the cmake will sort out the MSVC project to handle it. |
worktycho
referenced this issue
May 25, 2014
Closed
Replace the compiled tolua with system lua where available. #1031
bearbin
removed
the
enhancement
label
Oct 3, 2014
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Bump because as of #1687 this will speed up travis builds. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
PaddyMac
Feb 4, 2016
I was thinking about opening a new bug, but then I found this open bug. I'd actually like to see the option to use system libraries for all of the dependencies if possible - maybe with a cmake commandline switch.
PaddyMac
commented
Feb 4, 2016
|
I was thinking about opening a new bug, but then I found this open bug. I'd actually like to see the option to use system libraries for all of the dependencies if possible - maybe with a cmake commandline switch. |
worktycho commentedMar 1, 2014
Cmake provides a function FindLua51 to locate the system lua install if installed. We should use this function to find the system lua and use that instead of our own if installed. This should be bypassed when the CROSS_COMPILING flag is set so as to avoid dependencies on the build machine.