New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The build system should use FindLua51 to load the system lua if present #739

Open
worktycho opened this Issue Mar 1, 2014 · 4 comments

Comments

Projects
None yet
4 participants
@worktycho
Member

worktycho commented Mar 1, 2014

Cmake provides a function FindLua51 to locate the system lua install if installed. We should use this function to find the system lua and use that instead of our own if installed. This should be bypassed when the CROSS_COMPILING flag is set so as to avoid dependencies on the build machine.

@madmaxoft

This comment has been minimized.

Show comment
Hide comment
@madmaxoft

madmaxoft Mar 1, 2014

Member

I'm not sure how that would work on Windows in MSVC - if there's no Lua project in the solution, then MCServer won't compile against any Lua.

Member

madmaxoft commented Mar 1, 2014

I'm not sure how that would work on Windows in MSVC - if there's no Lua project in the solution, then MCServer won't compile against any Lua.

@worktycho

This comment has been minimized.

Show comment
Hide comment
@worktycho

worktycho Mar 1, 2014

Member

It sets a variable to the path of the lua libraries. Cmake and MSVC both support linking in external libraries. we just have to import the system lua library as the lua target the cmake will sort out the MSVC project to handle it.

Member

worktycho commented Mar 1, 2014

It sets a variable to the path of the lua libraries. Cmake and MSVC both support linking in external libraries. we just have to import the system lua library as the lua target the cmake will sort out the MSVC project to handle it.

@worktycho

This comment has been minimized.

Show comment
Hide comment
@worktycho

worktycho Dec 25, 2014

Member

Bump because as of #1687 this will speed up travis builds.

Member

worktycho commented Dec 25, 2014

Bump because as of #1687 this will speed up travis builds.

@PaddyMac

This comment has been minimized.

Show comment
Hide comment
@PaddyMac

PaddyMac Feb 4, 2016

I was thinking about opening a new bug, but then I found this open bug. I'd actually like to see the option to use system libraries for all of the dependencies if possible - maybe with a cmake commandline switch.

PaddyMac commented Feb 4, 2016

I was thinking about opening a new bug, but then I found this open bug. I'd actually like to see the option to use system libraries for all of the dependencies if possible - maybe with a cmake commandline switch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment