Bow and arrow fixes

[Howaner]

• Add bow charging animation.
• Fix bow sounds.
• Players in survival mode can't pick up the arrow, when the shooter was in creative-mode.

[archshift]

Please, some description! What does your PR add? You should have a descriptive title and comment that explains what you actually did.

[archshift]

Please, some description! What does your PR add? You should have a descriptive title and comment that explains what you actually did.

[Howaner]

Changed.

[Howaner]

Changed.

[madmaxoft]

I still don't understand why you're checking the m_PickupState for the arrow. It's already been checked by CanPickup, and there ARE arrows that can be picked even in creative. Vanilla doesn't create them, but obeys them when created using NBT editors.

[madmaxoft]

I still don't understand why you're checking the m_PickupState for the arrow. It's already been checked by CanPickup, and there ARE arrows that can be picked even in creative. Vanilla doesn't create them, but obeys them when created using NBT editors.

[Howaner]

Only creative player can pickup arrows from other creative players.
But the arrow wouldn't add to the inventory.

Vanilla:
https://github.com/Bukkit/mc-dev/blob/master/net/minecraft/server/EntityArrow.java#L372

[Howaner]

Only creative player can pickup arrows from other creative players.
But the arrow wouldn't add to the inventory.

Vanilla:
https://github.com/Bukkit/mc-dev/blob/master/net/minecraft/server/EntityArrow.java#L372

[madmaxoft]

You shouldn't check the m_PickupState then, but the player instead, if they are in Creative. And add a comment along those lines to the source.

[madmaxoft]

You shouldn't check the m_PickupState then, but the player instead, if they are in Creative. And add a comment along those lines to the source.

[madmaxoft]

@Howaner could you fix the PR so that we can merge it in? Issue #1127 will conflict with this PR, so I'd prefer to have it merged already :)

[madmaxoft]

@Howaner could you fix the PR so that we can merge it in? Issue #1127 will conflict with this PR, so I'd prefer to have it merged already :)

[Howaner]

done

[Howaner]

done

[madmaxoft]

I merged the code, but I had to remove the BroadcastCollectPickup() call. It expects a cPickup, you can't simply cast a cArrowEntity to a cPickup. The code compiles, but it will crash.
In order to implement proper collection broadcast, you will need to change the BroadcastCollectPickup function: Rename it to BroadcastCollectEntity, make it take a cEntity & and the protocol will have to see what packet to send, based on the entity type (pickup / arrow / XP orb (?) / ...), if it even needs to distinguish between those. If not, even better, we can make "collectible creepers" :)

[madmaxoft]

I merged the code, but I had to remove the BroadcastCollectPickup() call. It expects a cPickup, you can't simply cast a cArrowEntity to a cPickup. The code compiles, but it will crash.
In order to implement proper collection broadcast, you will need to change the BroadcastCollectPickup function: Rename it to BroadcastCollectEntity, make it take a cEntity & and the protocol will have to see what packet to send, based on the entity type (pickup / arrow / XP orb (?) / ...), if it even needs to distinguish between those. If not, even better, we can make "collectible creepers" :)

[tigerw]

But the arrow collection animation was working fine before with that call.

[tigerw]

But the arrow collection animation was working fine before with that call.

[madmaxoft]

That's just a coincidence that it worked for you, the C++ standard says it's an undefined behavior, so the program was allowed to start a nuclear war and it'd still be correct.

[madmaxoft]

That's just a coincidence that it worked for you, the C++ standard says it's an undefined behavior, so the program was allowed to start a nuclear war and it'd still be correct.

[worktycho]

@tigerw working is a valid value of anything can happen.

[worktycho]

@tigerw working is a valid value of anything can happen.

[tigerw]

Ah. I've always wondered about undefined behaviour and the law.

If the program, through undefined behaviour, commits a crime (blackmailing your neighbour's cat, for example), who is responsible? The standard makers? The compiler programmers? The programmer? The program as a legal entity? Is it a grey area?

If there is no punishment, who gives the authority for the program to do what it likes?

[tigerw]

Ah. I've always wondered about undefined behaviour and the law.

If the program, through undefined behaviour, commits a crime (blackmailing your neighbour's cat, for example), who is responsible? The standard makers? The compiler programmers? The programmer? The program as a legal entity? Is it a grey area?

If there is no punishment, who gives the authority for the program to do what it likes?

[worktycho]

@tigerw probably the company/organisation responsible for creating the program. See the Toyota case. However it is a bit of a grey area as there haven't been many cases of programs committing crimes through failure.

[worktycho]

@tigerw probably the company/organisation responsible for creating the program. See the Toyota case. However it is a bit of a grey area as there haven't been many cases of programs committing crimes through failure.