/cuberite

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rough ravines gen #1252

Merged
merged 5 commits into from Jul 29, 2014

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@madmaxoft @NiLSPACE @tigerw
@madmaxoft
Member

madmaxoft commented Jul 27, 2014

Adds a RoughRavines finisher generator that generates twisted ravines with ledges.

madmaxoft added some commits Jul 26, 2014

@madmaxoft
RoughRavines: Initial generator implementation. 
This provides the basic shape of the ravines, with the basic settings based on GridStructGen, and good default values.
77f4297
@madmaxoft
RoughRavines: More settings - size, width, roughness
472f70a
@madmaxoft
RoughRavines: Added per-height radius modifier. Ledges!
960ab98
@madmaxoft
RoughRavines: Made floor and ceiling settings-adjustable. 
The world.ini has settings for the minimum and maximum height for each at the ravines' center and edges.
Loading status checks…
30893e7
@madmaxoft

This comment has been minimized.

Show comment
Hide comment
@madmaxoft

madmaxoft Jul 27, 2014

Member

Example:
Ravines example
Member

madmaxoft commented Jul 27, 2014

Example:
Ravines example
@NiLSPACE

This comment has been minimized.

Show comment
Hide comment
@NiLSPACE

NiLSPACE Jul 27, 2014

Member

The build failed.
Member

NiLSPACE commented Jul 27, 2014

The build failed.
src/Generating/RoughRavines.cpp
case E_BLOCK_DIAMOND_ORE:
case E_BLOCK_REDSTONE_ORE:
case E_BLOCK_REDSTONE_ORE_GLOWING:
{

This comment has been minimized.

Show comment
Hide comment
@NiLSPACE

NiLSPACE Jul 28, 2014

Member

I think we forgot mycelium. Same is for normal caves.
Copy link
@NiLSPACE

NiLSPACE Jul 28, 2014

Member

I think we forgot mycelium. Same is for normal caves.

This comment has been minimized.

Show comment
Hide comment
@madmaxoft

madmaxoft Jul 28, 2014

Member

And all the new ores and -ites from 1.8.
Copy link
@madmaxoft

madmaxoft Jul 28, 2014

Member

And all the new ores and -ites from 1.8.

This comment has been minimized.

Show comment
Hide comment
@NiLSPACE

NiLSPACE Jul 28, 2014

Member

Those new stone variants? They are all E_BLOCK_STONE but with a different meta if I remember correctly.
Copy link
@NiLSPACE

NiLSPACE Jul 28, 2014

Member

Those new stone variants? They are all E_BLOCK_STONE but with a different meta if I remember correctly.

This comment has been minimized.

Show comment
Hide comment
@NiLSPACE

NiLSPACE Jul 29, 2014

Member

Oh and Hardened/stained clay.
Copy link
@NiLSPACE

NiLSPACE Jul 29, 2014

Member

Oh and Hardened/stained clay.

This comment has been minimized.

Show comment
Hide comment
@madmaxoft

madmaxoft Jul 29, 2014

Member

We should make a specific cBlockInfo::CanBeTerraformed(BLOCKTYPE) method that all the generators will use. Perhaps even export it to Lua.
Copy link
@madmaxoft

madmaxoft Jul 29, 2014

Member

We should make a specific cBlockInfo::CanBeTerraformed(BLOCKTYPE) method that all the generators will use. Perhaps even export it to Lua.

This comment has been minimized.

Show comment
Hide comment
@NiLSPACE

NiLSPACE Jul 29, 2014

Member

Yea that would make things easier. I guess we won't do that in this PR?
Copy link
@NiLSPACE

NiLSPACE Jul 29, 2014

Member

Yea that would make things easier. I guess we won't do that in this PR?

This comment has been minimized.

Show comment
Hide comment
@madmaxoft

madmaxoft Jul 29, 2014

Member

A separate PR will be better, right.
Copy link
@madmaxoft

madmaxoft Jul 29, 2014

Member

A separate PR will be better, right.

This comment has been minimized.

Show comment
Hide comment
@NiLSPACE

NiLSPACE Jul 29, 2014

Member

I'm working on the new PR right now.
Copy link
@NiLSPACE

NiLSPACE Jul 29, 2014

Member

I'm working on the new PR right now.
@madmaxoft

This comment has been minimized.

Show comment
Hide comment
@madmaxoft

madmaxoft Jul 29, 2014

Member

Anyone against merging this in?
Member

madmaxoft commented Jul 29, 2014

Anyone against merging this in?
@NiLSPACE

This comment has been minimized.

Show comment
Hide comment
@NiLSPACE

NiLSPACE Jul 29, 2014

Member

I'd say merge :)
Member

NiLSPACE commented Jul 29, 2014

I'd say merge :)
@tigerw

This comment has been minimized.

Show comment
Hide comment
@tigerw

tigerw Jul 29, 2014

Member

Geen bezwaren?
Member

tigerw commented Jul 29, 2014

Geen bezwaren?

madmaxoft added a commit that referenced this pull request Jul 29, 2014

@madmaxoft
Merge pull request #1252 from mc-server/RoughRavinesGen 
Rough ravines gen
Loading status checks…
8287f2d

@madmaxoft madmaxoft merged commit 8287f2d into master Jul 29, 2014
2 checks passed

2 checks passed

continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci The Travis CI build passed
Details

@NiLSPACE NiLSPACE deleted the RoughRavinesGen branch Jul 29, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment