Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdded SetDoDaylightCycle() and IsDaylightCycleEnabled() to cWorld. #1296
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
archshift
Aug 6, 2014
Contributor
I think CycleDaylight would be a better name for the bool than DoDaylightCycle, but there's probably a better name that I can't think of right now.
|
I think |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Howaner
Aug 7, 2014
Contributor
And what is a good name for the functions?
SetCycleDaylight(); GetCycleDaylight() ?
|
And what is a good name for the functions? |
madmaxoft
reviewed
Aug 8, 2014
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Ahem. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
tigerw
Aug 8, 2014
Member
Don't forget to write m_IsDaylightCycleEnabled to file in cWorld's destructor, as it is plugin changeable.
|
Don't forget to write m_IsDaylightCycleEnabled to file in cWorld's destructor, as it is plugin changeable. |
Howaner
added some commits
Aug 10, 2014
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
done. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
done. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
done. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Me likes. If there are no other objections, merge. |
Howaner commentedAug 6, 2014
I need this for a GameRule plugin.