Added dungeon rooms finisher.

[madmaxoft]

This implements #1260.

The DungeonRooms finisher adds dungeon rooms to the generated worlds. The rooms' placement is based on a GridStructGen, the rooms will contain 2 chests each.

[NiLSPACE]

Vanilla doesn't check if the chests would form a double chest, so do we want to do the same?

[NiLSPACE]

Vanilla doesn't check if the chests would form a double chest, so do we want to do the same?

[madmaxoft]

I believe it does, because there are rendering errors if they are not checked:

(the second chest is in the highlighted block, but because the primary chest's meta is wrong, the renderer draws the doublechest to the wrong side)

[madmaxoft]

I believe it does, because there are rendering errors if they are not checked:

(the second chest is in the highlighted block, but because the primary chest's meta is wrong, the renderer draws the doublechest to the wrong side)

[NiLSPACE]

Double chests are noted in the trivia from the wiki.
EDIT:
Maybe Mojang does some meta magic to make them look good?

[NiLSPACE]

Double chests are noted in the trivia from the wiki.
EDIT:
Maybe Mojang does some meta magic to make them look good?

[madmaxoft]

I think I'll use the path-of-least-resistance for the dblchest - I will make it so that no single dungeon generates its chest next to each other. This will fix the vast majority of the bad cases, the only remaining problems will be with overlapping dungeons; I will ignore them for the time being, because a proper solution might be impossible to implement (imagine someone setting the generator to generate a dungeon for each column, there would be so many chests that it might be impossible to place them properly)

[madmaxoft]

I think I'll use the path-of-least-resistance for the dblchest - I will make it so that no single dungeon generates its chest next to each other. This will fix the vast majority of the bad cases, the only remaining problems will be with overlapping dungeons; I will ignore them for the time being, because a proper solution might be impossible to implement (imagine someone setting the generator to generate a dungeon for each column, there would be so many chests that it might be impossible to place them properly)

[tigerw]

"...profiling for x64..."
"...dungeons..."

Hm.

[tigerw]

"...profiling for x64..."
"...dungeons..."

Hm.

[madmaxoft]

I know I know, I'm turning into a tigerw :P

[madmaxoft]

I know I know, I'm turning into a tigerw :P

[madmaxoft]

I think this is now feature-complete. Comments?

[madmaxoft]

I think this is now feature-complete. Comments?

[NiLSPACE]

Yea it looks nice. I'd say that we can merge.

[NiLSPACE]

Yea it looks nice. I'd say that we can merge.

[NiLSPACE]

Did you forget one side?:

[NiLSPACE]

Did you forget one side?:

[madmaxoft]

No, all sides should be accounted for. Can you give me the coords and world.ini for that screenshot?

[madmaxoft]

No, all sides should be accounted for. Can you give me the coords and world.ini for that screenshot?

[NiLSPACE]

I don't think that I can find the exact spot because I already moved on, but I'll search for another occurrence.

[NiLSPACE]

I don't think that I can find the exact spot because I already moved on, but I'll search for another occurrence.

[madmaxoft]

Found it. An off-by-one error in the fast-bail-out checking.

[madmaxoft]

Found it. An off-by-one error in the fast-bail-out checking.