Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upEnchanting table improvements. #1350
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
madmaxoft
Aug 28, 2014
Member
I seem unable to add line comments, so I'll write it just here, sorry.
src/UI/SlotArea.cpp, line 1474 (new): How about using std::swap instead? That should perform better than copy-assignment and then emptying.
|
I seem unable to add line comments, so I'll write it just here, sorry. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
madmaxoft
Aug 28, 2014
Member
Also, that part of code is not exactly clear to me, it could use some commenting on what's going on.
|
Also, that part of code is not exactly clear to me, it could use some commenting on what's going on. |
Howaner
added some commits
Aug 28, 2014
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
done. |
madmaxoft
reviewed
Aug 28, 2014
madmaxoft
reviewed
Aug 28, 2014
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
done. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
madmaxoft
Aug 30, 2014
Member
That's a pretty useless comment - what's an enchantment with a book? And what's one without a book?
|
That's a pretty useless comment - what's an enchantment with a book? And what's one without a book? |
Howaner
added some commits
Sep 2, 2014
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
I hope this comment is better. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Much better, thank you :) |
Howaner commentedAug 27, 2014
No description provided.