New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enchanting table improvements. #1350

Merged
merged 8 commits into from Sep 2, 2014

Conversation

Projects
None yet
3 participants
@Howaner
Contributor

Howaner commented Aug 27, 2014

No description provided.

Show outdated Hide outdated src/UI/SlotArea.cpp
@madmaxoft

This comment has been minimized.

Show comment
Hide comment
@madmaxoft

madmaxoft Aug 28, 2014

Member

I seem unable to add line comments, so I'll write it just here, sorry.
src/UI/SlotArea.cpp, line 1474 (new): How about using std::swap instead? That should perform better than copy-assignment and then emptying.

Member

madmaxoft commented Aug 28, 2014

I seem unable to add line comments, so I'll write it just here, sorry.
src/UI/SlotArea.cpp, line 1474 (new): How about using std::swap instead? That should perform better than copy-assignment and then emptying.

@madmaxoft

This comment has been minimized.

Show comment
Hide comment
@madmaxoft

madmaxoft Aug 28, 2014

Member

Also, that part of code is not exactly clear to me, it could use some commenting on what's going on.

Member

madmaxoft commented Aug 28, 2014

Also, that part of code is not exactly clear to me, it could use some commenting on what's going on.

@Howaner

This comment has been minimized.

Show comment
Hide comment
@Howaner

Howaner Aug 28, 2014

Contributor

done.

Contributor

Howaner commented Aug 28, 2014

done.

Show outdated Hide outdated src/Item.h
Show outdated Hide outdated src/Item.h
@Howaner

This comment has been minimized.

Show comment
Hide comment
@Howaner

Howaner Aug 30, 2014

Contributor

done.

Contributor

Howaner commented Aug 30, 2014

done.

@madmaxoft

This comment has been minimized.

Show comment
Hide comment
@madmaxoft

madmaxoft Aug 30, 2014

Member

That's a pretty useless comment - what's an enchantment with a book? And what's one without a book?

Member

madmaxoft commented Aug 30, 2014

That's a pretty useless comment - what's an enchantment with a book? And what's one without a book?

@Howaner

This comment has been minimized.

Show comment
Hide comment
@Howaner

Howaner Sep 2, 2014

Contributor

I hope this comment is better.

Contributor

Howaner commented Sep 2, 2014

I hope this comment is better.

@madmaxoft

This comment has been minimized.

Show comment
Hide comment
@madmaxoft

madmaxoft Sep 2, 2014

Member

Much better, thank you :)

Member

madmaxoft commented Sep 2, 2014

Much better, thank you :)

madmaxoft added a commit that referenced this pull request Sep 2, 2014

Merge pull request #1350 from mc-server/Inventory
Enchanting table improvements.

@madmaxoft madmaxoft merged commit 82f2037 into master Sep 2, 2014

1 check was pending

continuous-integration/travis-ci The Travis CI build is in progress
Details

@archshift archshift deleted the Inventory branch Sep 2, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment