/cuberite

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should now compile in clang 3.0 #1385

Merged
merged 6 commits into from Sep 6, 2014

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@worktycho @bearbin @madmaxoft
@worktycho
Member

worktycho commented Sep 6, 2014

Fixed various warning flags that don't exist in clang 3.0

@worktycho worktycho referenced this pull request Sep 6, 2014

Closed

Unknown Warning options in BlockBed.h #1383

@worktycho

This comment has been minimized.

Show comment
Hide comment
@worktycho

worktycho Sep 6, 2014

Member

Helpfully clang doesn't seem to be defining the correct IDs.
Member

worktycho commented Sep 6, 2014

Helpfully clang doesn't seem to be defining the correct IDs.
@worktycho

This comment has been minimized.

Show comment
Hide comment
@worktycho

worktycho Sep 6, 2014

Member

Should now work on clang 3.0
Member

worktycho commented Sep 6, 2014

Should now work on clang 3.0
@bearbin

This comment has been minimized.

Show comment
Hide comment
@bearbin

bearbin Sep 6, 2014

Member

Debian stable only has Clang 2.8.9
Member

bearbin commented Sep 6, 2014

Debian stable only has Clang 2.8.9
@worktycho

This comment has been minimized.

Show comment
Hide comment
@worktycho

worktycho Sep 6, 2014

Member

Yes. and travis only has cmake 2.8.7. I'm working on a workaround now.
Member

worktycho commented Sep 6, 2014

Yes. and travis only has cmake 2.8.7. I'm working on a workaround now.
@worktycho

This comment has been minimized.

Show comment
Hide comment
@worktycho

worktycho Sep 6, 2014

Member

Workaround implemented.
Member

worktycho commented Sep 6, 2014

Workaround implemented.
Show outdated Hide outdated SetFlags.cmake
@worktycho

This comment has been minimized.

Show comment
Hide comment
@worktycho

worktycho Sep 6, 2014

Member

Fixed
Member

worktycho commented Sep 6, 2014

Fixed

madmaxoft added a commit that referenced this pull request Sep 6, 2014

@madmaxoft
Merge pull request #1385 from mc-server/clangWarnings 
Should now compile in clang 3.0
c71a370

@madmaxoft madmaxoft merged commit c71a370 into master Sep 6, 2014
1 check passed

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@worktycho worktycho deleted the clangWarnings branch Sep 6, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment