Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upRedstone fix #1461
Conversation
worktycho
added some commits
Sep 27, 2014
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
The *.inc file is still not good though. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Merging as hotfix, if that is the correct term. |
added a commit
that referenced
this pull request
Sep 27, 2014
tigerw
merged commit 28ebe11
into
master
Sep 27, 2014
1 check passed
tigerw
deleted the
RedstoneFix
branch
Sep 27, 2014
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
madmaxoft
Sep 27, 2014
Member
Why don't you use the approach used by all the other simulators - they each have a virtual method that creates the per-chunk data, and the chunk's constructor calls this method, so it always has a valid pointer to the simulator data. Or is there a problem with this and the splitting?
We could even make that method abstract within cSimulator itself, so each and every simulator has to override it.
|
Why don't you use the approach used by all the other simulators - they each have a virtual method that creates the per-chunk data, and the chunk's constructor calls this method, so it always has a valid pointer to the simulator data. Or is there a problem with this and the splitting? We could even make that method abstract within |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
worktycho
Sep 27, 2014
Member
The reason I didn't do that is that this is was hotfix and I didn't know about the factory method. I'm happy to rewrite it to use the factory method pattern.
|
The reason I didn't do that is that this is was hotfix and I didn't know about the factory method. I'm happy to rewrite it to use the factory method pattern. |
worktycho commentedSep 27, 2014
Fixes #1460
Fixes #1458