Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upcoverity #1902
Conversation
madmaxoft
and others
added some commits
Apr 16, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
NiLSPACE
Apr 20, 2015
Member
The server doesn't compile anymore now.
`
/home/travis/build/mc-server/MCServer/src/Items/ItemHandler.cpp:290:20: error:
comparison of integers of different signs: 'int' and 'unsigned long'
[-Werror,-Wsign-compare]
for (int i = 0; i < ARRAYCOUNT(m_ItemHandler); i++)
~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~
`
|
The server doesn't compile anymore now. ` |
madmaxoft
added some commits
Apr 20, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
NiLSPACE
Apr 20, 2015
Member
We might want to provide some basic info, like the port number and if the server is authenticating mode.
|
We might want to provide some basic info, like the port number and if the server is authenticating mode. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
madmaxoft
Apr 20, 2015
Member
That could go into the front page, I don't think it's that useful on every page.
|
That could go into the front page, I don't think it's that useful on every page. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Yeah, that's what I was thinking. Just the front page would be better. |
NiLSPACE
and others
added some commits
Apr 20, 2015
madmaxoft
and others
added some commits
Apr 21, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
NiLSPACE
Apr 23, 2015
Member
But should we really count clay as an ore? Sure it spawns in veins, but it's not something I would think of when talking about an ore.
|
But should we really count clay as an ore? Sure it spawns in veins, but it's not something I would think of when talking about an ore. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
madmaxoft
Apr 23, 2015
Member
I think any block that converts to different items when broken qualifies as an ore. At least good enough for me.
|
I think any block that converts to different items when broken qualifies as an ore. At least good enough for me. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jammet
Apr 26, 2015
Contributor
Digging up clay today ... sadly this did not fix it. I still do get the clay block instead of, .. the "ore".
|
Digging up clay today ... sadly this did not fix it. I still do get the clay block instead of, .. the "ore". |
madmaxoft
and others
added some commits
Apr 23, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
And here I was expecting the issue to be really hard to fix :P |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
madmaxoft
Apr 25, 2015
Member
It had to be already implemented for the pre-refactoring code to work, so it had to be just a matter of searching for the right code to call.
|
It had to be already implemented for the pre-refactoring code to work, so it had to be just a matter of searching for the right code to call. |
madmaxoft
and others
added some commits
Apr 25, 2015
added a commit
that referenced
this pull request
Apr 26, 2015
worktycho commentedApr 26, 2015
No description provided.